1539804 - re-enable browser_urlbarStopSearchOnSelection.js for Quantumbar

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Comment 1

[Drew Willcoxon :adw]

The event buffering in quantumbar seems to be different enough from awesomebar that porting this isn't quite as simple as I first thought.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems.

This test uncovered a couple of problems:

(1) UrlbarController.handleKeyNavigation relies on event.defaultPrevented to tell whether the one-offs handled the key event. That's a problem when combined with deferring the down arrow key.

handleKeyNavigation is called twice in that case. The first time, the event is deferred (so executeAction = false), and handleKeyNavigation calls event.preventDefault. The second time, the event is being replayed, but defaultPrevented is true from the previous call regardless of whether the one-offs actually handled the event.

So handleKeyNavigation always returns early because it thinks the one-offs always handled the event, so it never properly replays down arrow keys.

(2) UrlbarProviderUnifiedComplete's query promise is never resolved when the query is canceled. That's a problem in general of course but I tripped over it in this test because I need to check results after the query is canceled, and the test ended up hanging since UrlbarTestUtils waits for the query to finish in order to get its results.

It's not a problem in UnifiedComplete itself per se because of course awesomebar uses UnifiedComplete too, and it doesn't have this problem. The difference is that nsAutoCompleteController::StopSearch calls input->OnSearchComplete() (via PostSearchCleanup): https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/toolkit/components/autocomplete/nsAutoCompleteController.cpp#1433

Quantumbar's UnifiedComplete provider is missing that behavior, so this patch adds it by resolving its query promise when the query is canceled.

Comment 3

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c6e308a0929cad0b5b6e26e47441d21b9f8a725

Comment 4

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b6380e08d3910f1987043bd03fc660cbc0363d1

Comment 5

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9901a8cd839567bbff3644f286c3cab31321490

Comment 6

[Drew Willcoxon :adw]

Finally got a green try run, so I'll land this now. https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d66bceaaca1cd5de45a7fca7d53e70b41d25864

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9242458b79d5
Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak

Comment 8

[Andrei Ciure[:aciure]]

Backed out changeset 9242458b79d5 (bug 1539804) for high frequency browser/browser_urlbarStopSearchOnSelection.js failures

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=9242458b79d5ae6e9d48c9a2a591680d79c13211

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&fromchange=cbdf3fdfcbac59d4ccac118d2e6a96ac360a94a5&selectedJob=243871875

backout: https://hg.mozilla.org/integration/autoland/rev/99548c52b81f7b1ff00f0fef2eb713911ab4e830

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99548c52b81f
Backed out changeset 9242458b79d5 for high frequency browser/browser_urlbarStopSearchOnSelection.js failures CLOSED TREE

Comment 10

[Drew Willcoxon :adw]

Verify run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76f081fe9acd3f5faf37b5787fb353022e429704

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7ad04ab4ba4
Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a7ad04ab4ba4