Open Bug 1539864 Opened 7 years ago Updated 1 year ago

Need a way to handle MOZ_CAN_RUN_SCRIPT in IPDL-generated code

Categories

(Core :: IPC, enhancement, P3)

enhancement

Tracking

()

Tracking Status
firefox68 --- affected

People

(Reporter: bzbarsky, Unassigned)

References

(Blocks 1 open bug)

Details

No description provided.

Right now the only thing to do is to mark the Recv method as CAN_RUN_SCRIPT_BOUNDARY and ensure this is rooted, right?

I'm not sure we can do better until all IPDL actors are reference counted, but maybe I'm missing a good solution.

That seems reasonable, yes. Right now I have been marking Recv* implementation as MOZ_CAN_RUN_SCRIPT_BOUNDARY, but it would be best if the boundary annotation were in the generated code and the generated code ensured the rooting...

I think making the calling code (OnReceiveMessage) actually ensure the rooting requires bug 1509143.

OK. I don't have strong opinions on how we do it. For now, I have been annotating the relevant MOZ_CAN_RUN_SCRIPT_BOUNDARY markers with comments explaining why we have a boundary...

Depends on: 1540731
Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.