1541465 - Firefox Screenshot tool crashes on pages with IPv6 Address

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect, P3)

Description

[sedrubal]

Attachment: Error_notification.png

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

I opened a page using its IPv6 Address (e.g. http://[::1]:8080/) and tried to take a screenshot (using right click > Take a screenshot)

Actual results:

The tool did not take a screenshot but the notification I attached popped up.

An exception is thrown in shot.js in assertUrl, because originFromUrl returns a broken URL. The regex in originFromUrl (const match = (/^https?://[^/:]{1,4000}/i).exec(url);) cannot handle the ':' in IPv6 Addresses. I'm not sure, but why don't you use (window.)location.origin instead of parsing the URL?

Expected results:

The screenshot tool should be able to handle IPv6 Addresses.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:ianbicking, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Janis]

This still happens in Firefox 88.
The following error appears in the browser console:

Unhandled error: Error: Not a URL
    assertUrl moz-extension://1ee5ddd0-0b25-4a5a-9d8a-9edcc7dfa94f/build/shot.js:45
    assertOrigin moz-extension://1ee5ddd0-0b25-4a5a-9d8a-9edcc7dfa94f/build/shot.js:56
    set origin moz-extension://1ee5ddd0-0b25-4a5a-9d8a-9edcc7dfa94f/build/shot.js:334
    AbstractShot moz-extension://1ee5ddd0-0b25-4a5a-9d8a-9edcc7dfa94f/build/shot.js:183
    <anonymous> moz-extension://1ee5ddd0-0b25-4a5a-9d8a-9edcc7dfa94f/selector/shooter.js:135
    catcher moz-extension://1ee5ddd0-0b25-4a5a-9d8a-9edcc7dfa94f/catcher.js:59
    shooter moz-extension://1ee5ddd0-0b25-4a5a-9d8a-9edcc7dfa94f/selector/shooter.js:143
    <anonymous> moz-extension://1ee5ddd0-0b25-4a5a-9d8a-9edcc7dfa94f/selector/shooter.js:146
 undefined catcher.js:21:11

Comment 5

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1541465 - Firefox Screenshot tool crashes on pages with IPv6 Address. r=sfoster!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57dd75cfb7aa
Firefox Screenshot tool crashes on pages with IPv6 Address. r=sfoster

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/57dd75cfb7aa