1541771 - Crash in [@ mozilla::dom::`anonymous namespace'::InitUsageForOrigin]

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, defect, P1)

Description

[Jan Varga [:janv]]

This bug is for crash report bp-41c614d9-09a4-4005-9bcf-9e2280190404.

Top 10 frames of crashing thread:

0 xul.dll static void mozilla::dom::`anonymous namespace'::InitUsageForOrigin dom/localstorage/ActorsParent.cpp:2777
1 xul.dll nsresult mozilla::dom::`anonymous namespace'::QuotaClient::InitOrigin dom/localstorage/ActorsParent.cpp:7663
2 xul.dll nsresult mozilla::dom::quota::QuotaManager::InitializeOrigin dom/quota/ActorsParent.cpp:4094
3 xul.dll nsresult mozilla::dom::quota::QuotaManager::InitializeRepository dom/quota/ActorsParent.cpp:3963
4 xul.dll nsresult mozilla::dom::quota::QuotaManager::EnsureTemporaryStorageIsInitialized dom/quota/ActorsParent.cpp:5321
5 xul.dll mozilla::dom::quota::QuotaManager::EnsureOriginIsInitializedInternal dom/quota/ActorsParent.cpp:5248
6 xul.dll nsresult mozilla::dom::indexedDB::`anonymous namespace'::OpenDatabaseOp::DoDatabaseWork dom/indexedDB/ActorsParent.cpp:19818
7 xul.dll nsresult mozilla::dom::indexedDB::`anonymous namespace'::FactoryOp::Run dom/indexedDB/ActorsParent.cpp:19662
8 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1180
9 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:482

Comment 1

[Julien Cristau [:jcristau]]

Just noting here that this was triggered by bug 1540401 which is now backed out, so these are back to just debug asserts now.

Comment 2

[Jan Varga [:janv]]

This looks like bug 1514600.

Comment 4

[Jan Varga [:janv]]

(In reply to Jan Varga [:janv] from comment #2)

This looks like bug 1514600.

Yeah, but bug 1514600 is less likely to happen.
There's another problem. If I go to preferences immediately after FF is launched, quota manager gets GetUsage request and since temporary storage is not yet initialized, it uses client->InitOrigin() for getting usage. The problem is that LSNG caches the usage information and when temporary storage is being initialized it asserts that we already initialized given origin (already have a cached entry for that).
We should probably pass a flag to InitOrigin that it's not called as part of temporary storage initialization.

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1541771 - LSNG: Don't cache usage in InitOrigin if it's not for temporary storage initialization; r=asuth

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1583103d9715
LSNG: Don't cache usage in InitOrigin if it's not for temporary storage initialization; r=asuth

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1583103d9715

Comment 8

[[:philipp]]

this crash signature is still present in builds after the patch has landed.

Comment 9

[[:philipp]]

crashes are only reported from nightly/devedition builds

Comment 10

[Jan Varga [:janv]]

This is now fixed. See bug 1540401 comment 37.