1542353 - Confirming a Download while moving tabs freezes the tabs in a wrong position and makes the URL bar unreachable

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[ajendu003]

Attachment: Capture d’écran 2019-04-05 à 20.51.31.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

I downloaded a file from QT. The download pop up took a bit of time to come (3-4 seconds) so i went to another tab (with youtube) and tried to move it on the right of my current tab. That's when the download pop up appeared and I accepted it while the tab was NOT is it's final position.

(I'm on macOS)

Actual results:

The tab stayed in the position it was (you can still switch between them). The URL bar became unreachable (clicking won't do anything)

Expected results:

The URL bar should still be reachable and the tab would either go back to it's original position or at least choose a position.

Comment 1

[Alice0775 White]

Attachment: Screenshot Nightly68.0a1 Windows10.

I can also reproduce the issue on Nightly68.0a1 Windows10.
The tab position is incorrect. Addressbar stops working against all tabs.

Comment 2

[Alice0775 White]

#1 problem: The tab position is incorrect
#2 problem: Addressbar stops working against all tabs.

Regression window for #1 problem:
at least since Firefox2: tab drop indicator would not disappear.
since Firefox17: The tab position is incorrect, overlaps.

Regression window for #2 problem:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=865d5faef4a7d034500efae76e66e5216541b3d9&tochange=481d7cc2f6f06ea35794403dc9291d277910d6b9

Triggered by:
481d7cc2f6f0 Jared Wein — Bug 450915 - Increase the drag space of the TabsToolbar by 15px on the bottom to improve the tab reordering experience. r=Gijs

Comment 3

[Alice0775 White]

When the #2 problem is occurred,
remove |movingtab="true"| from toolbox "navigator-toolbox", then the addressbar works again.

Comment 6

[:Gijs (he/him)]

I suspect the suggestion in bug 1544167 could be used to fix this.

Comment 8

[Paul Zühlcke [:pbz]]

Given that this is S2 and also affects other prompts like HTTP auth, I think we should prioritize it.

Comment 9

[:Gijs (he/him)]

I believe I fixed this in bug 1544167 but it'd be good to have it independently verified.

Comment 10

[Ciprian Georgiu, Desktop QA]

Hi ajendu003! Are you still experiencing this issue on the latest Beta builds? It was fixed some time ago, and in case the issue is not reproducing anymore on you end, we can close it as verified fixed.

Unfortunately, I cannot confirm this on my Win 10 machine or macOS 11, because I wasn't able to reproduce the bug on an affected Nightly build, 2019-04-05.