Closed Bug 1542863 Opened 6 months ago Closed 4 months ago

Make sure there’s a good fallback experience when the load times out (& have it timeout)

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 69
Iteration:
69.2 - May 27 - Jun 9
Tracking Status
firefox69 --- verified

People

(Reporter: gsuntop, Assigned: thecount)

References

(Blocks 1 open bug)

Details

(Keywords: github-merged)

Attachments

(1 file)

Design & implement an experience for when feed and/or template load requests time out.

Also, need to determine what an acceptable timeout is exactly.

Type: defect → enhancement
Assignee: nobody → wkonu

Assigning to Wolasi for UX.

Blocks: 1534775

:gvn

  • The timeout only affects Top Sites, Pocket Stories, and Highlights right? Search will be displayed regardless right?
  • Is it in scope to automatically kick of another request for data after the timeout? Or is the expectation a manual reload by the user?
Flags: needinfo?(gsuntop)

I believe search always shows up, yes.

Not in scope to kick off another request AFAIK. I believe best approach would be to show some error messaging.

Flags: needinfo?(gsuntop)

Goal for this bug: Wolasi to have UX by 4/12 - Gavin be able to implement by 4/19. Thanks!

Iteration: 68.2 - Apr 1 - 14 → 68.3 - Apr 15 - 28
Keywords: uiwanted

Can we show a refresh button with the message?

Flags: needinfo?(gsuntop)

Yes, but bear in mind that there are multiple potential failure scenarios:

  1. Layout request fails (entire page can't render)
  2. Individual feed request fails (only component(s) dependent on that feed will fail to render...I think)
Flags: needinfo?(gsuntop)

Scott, do you know if a single feed failure will stop the entire layout from rendering?

Flags: needinfo?(sdowne)

One feed should not stop the rest. The layout failure though would.

I think what happens is when 1 feed fails, it's a network issue and all are likely to fail anyway, including the layout.

Flags: needinfo?(sdowne)

MVP for this week (68): Request has to timeout. Needs timeout threshold.

UX: render local copy by default.

Assignee: wkonu → gsuntop

Vicky, do you have a sense of what the timeout threshold should be set to?

Flags: needinfo?(vchin)

Discussed with necko team and we agreed that the timeout threshold should be set to 45s.

Flags: needinfo?(vchin)
Assignee: gsuntop → sdowne
Iteration: 68.3 - Apr 15 - 28 → 68.4 - Apr 29 - May 12

Here's the spec, it covers the following timeout scenarios

  1. entire Pocket section fails to load
  2. a category content feed in the Pocket section fails to load

Note spec assumes that Top Sites will always be displayed. Ping @wolasi if you have implementation questions.

Figma Spec
https://www.figma.com/file/0xZkmT86rSXbGRB4eIvrn0ts/New-Tab-Spec-for-Fx-v68?node-id=526%3A55

Keywords: uiwanted

Non UI changes happened in https://bugzilla.mozilla.org/show_bug.cgi?id=1548353 so it now times out, it just doesn't apply any ui specific to the timeout or any other fails for that matter. If a layout fails, it now uses the default layout, and if a feed fails it displays nothing for that feed. Things like topsites and search always load. Spocs would just not display a spoc.

Iteration: 68.4 - Apr 29 - May 12 → 69.1 - May 13 - 26
Blocks: pocket-newtab-69
No longer blocks: 1534775, pocket-newtab-68

What's the latest on this?

Flags: needinfo?(sdowne)

I havn't started, and I can fit it in after Ad server work. It's scheduled for 69 and there is still time.

Flags: needinfo?(sdowne)
Iteration: 69.1 - May 13 - 26 → 69.2 - May 27 - Jun 9
Blocks: 1556862
No longer blocks: pocket-newtab-69

This got merged.

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Blocks: 1558441
Keywords: github-merged
Target Milestone: --- → Firefox 69

I have verified this issue with the latest Firefox Nightly (69.0a1 Build ID - 20190613215335) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now a user-friendly message and the "Try Again" button are displayed, according to the specs, if the entire Pocket section or a category content feed from a sections fails to load.

Status: RESOLVED → VERIFIED
See Also: → 1560260
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.