1543859 - Refactor treeOrder.js in sources-tree for readability & remove duplicate code

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P3)

Description

[Anthony Xie]

Within treeOrder.js, the file responsible for sorting the sourcesTree, we have a matcher function for each exception (index, debuggeeHost, etc.) because we want to account for these edge cases when sorting the sourcesTree.

We have duplicate code for each of these matcher functions and going forward, adding more edge cases will only result in more duplicate code and impact readability.

Comment 1

[Anthony Xie]

Given you find this is a valid issue, I'd like to work on it!

Comment 2

[Jason Laster [:jlast]]

Go for it!

Comment 3

[Jason Laster [:jlast]]

How's it going Anthony?

Comment 4

[Anthony Xie]

Hey Jason, thanks for checking in. I wanted to wait until Bug #1533418 was resolved before working on this. I've also been busy applying to jobs recently, will revisit this next week! But if someone wants to work on this in the meantime, happy to share what I've done so far and pair on the issue :)

Comment 5

[Anthony Xie [:ravefalcon92]]

Attachment: Refactored treeOrder code to remove duplicate code and make it simple to add new exceptions in sorting the sourcesTree

Refactored treeOrder code to remove duplicate code and make it simple to add
new exceptions in sorting the sourcesTree

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7667da75c98b
Refactored treeOrder code to remove duplicate code and make it simple to add r=davidwalsh

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7667da75c98b