Closed Bug 1544025 Opened 5 years ago Closed 5 years ago

Prefs: in-content dialogs in dark-mode still light

Categories

(Firefox :: Theme, defect, P5)

defect

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

When in dark-mode the prefs are dark but the dialogs are still light. The "Certificate Manager" and the "Device Manager" are a nice mix-up of light and dark.

Priority: -- → P5
Assignee: nobody → richard.marti
No longer blocks: 1519548
Attached image container-color.png

Screenshot how the updateSettingCrossUserWarningContainer looks on Windows with dark theme.

Attachment #9057952 - Attachment description: Apply the dark-mode to the dialogs too. → Bug 1544025 - Apply the dark-mode to the dialogs too.

Aryx, please can you land this patch? I've created it through Phab web UI.

My committer info is: Richard Marti <richard.marti@gmail.com>

Flags: needinfo?(aryx.bugmail)
Keywords: checkin-needed
Flags: needinfo?(aryx.bugmail)

Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15e3076c8198
Apply the dark-mode to the dialogs too. r=dao

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Regressions: 1545969
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: