Closed Bug 1544026 Opened 7 months ago Closed 7 months ago

Tabs in "Certificate Manager" are unreadable in dark-mode

Categories

(Firefox :: Theme, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-68b-p2])

Attachments

(1 file)

In dark-mode the tabs in "Certificate Manager" are unreadable because they don't change the colour in dark-mode.

Priority: -- → P3
No longer blocks: 1519548
Keywords: checkin-needed

Revision is blocked from landing due to missing author information

Flags: needinfo?(richard.marti)
Keywords: checkin-needed

How do I set the author? Phab says "Authored by Paenglab".

Flags: needinfo?(richard.marti)

I created the patch via the Phabricator Web UI. I don't want to install all this peaces on Windows as this is too complicated for the 2-3 patches I create for M-C in a year.

Why does the Web UI creation exists when it's not useful for the workflow?

The same will happen with bug 1544025 when it has r+.

Flags: needinfo?(richard.marti)
Flags: needinfo?(apavel)

Aryx is there a way to solve the above using the web ui?

Flags: needinfo?(apavel) → needinfo?(aryx.bugmail)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/ae450d67977b
Add a tab color for the in-content.dark-mode mode. r=dao

Did |arc patch D27311 --nobranch| and took the committer information from https://hg.mozilla.org/comm-central/rev/4f2702e359aa

Flags: needinfo?(aryx.bugmail)
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Whiteboard: [qa-68b-p2]
You need to log in before you can comment on or make changes to this bug.