1544026 - Tabs in "Certificate Manager" are unreadable in dark-mode

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Richard Marti (:Paenglab)]

In dark-mode the tabs in "Certificate Manager" are unreadable because they don't change the colour in dark-mode.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1544026 - Add a tab color for the in-content.dark-mode mode. r=dao

Comment 2

[Andreea Pavel [:apavel]]

Revision is blocked from landing due to missing author information

Comment 3

[Richard Marti (:Paenglab)]

How do I set the author? Phab says "Authored by Paenglab".

Comment 4

[Andreea Pavel [:apavel]]

Please see https://wiki.mozilla.org/Phabricator/FAQ#Lando_says_.22This_diff_does_not_have_the_proper_author_information_uploaded_to_Phabricator.22.2C_but_I_see_an_author_on_Phabricator._What.27s_wrong.3F

Comment 5

[Richard Marti (:Paenglab)]

I created the patch via the Phabricator Web UI. I don't want to install all this peaces on Windows as this is too complicated for the 2-3 patches I create for M-C in a year.

Why does the Web UI creation exists when it's not useful for the workflow?

The same will happen with bug 1544025 when it has r+.

Comment 6

[Andreea Pavel [:apavel]]

Aryx is there a way to solve the above using the web ui?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae450d67977b
Add a tab color for the in-content.dark-mode mode. r=dao

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Did |arc patch D27311 --nobranch| and took the committer information from https://hg.mozilla.org/comm-central/rev/4f2702e359aa

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ae450d67977b