Closed Bug 15441 Opened 25 years ago Closed 25 years ago

[dogfood]problems going back/forward to named anchors

Categories

(SeaMonkey :: General, defect, P3)

Product:
SeaMonkey
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: dbaron, Assigned: radha)

References

(
URL
)

Details

(Whiteboard: [PDT-] RN)

I'm assigning this to radha@netscape.com, owner of bug 3152. It spins off some of the issues in that bug. DESCRIPTION: The main problem is that forward is disabled after going to a named anchor and then going back. This seems related to the problem that named anchors do not show up in the URL bar. However, if one goes back another step and then forward again, forward is enabled, but it goes forward to the page without the named anchor, and stays enabled after going forward. STEPS TO REPRODUCE: 1) Load http://www.fas.harvard.edu/~dbaron/links/Internet 2) click "General" (third link) 3) Hit back button 4) Hit back button 5) Hit forward button 6) Hit forward button 7) Hit forward button ACTUAL RESULTS: * After step (2), the URL bar does not show the "#General" it should show at the end * After step (3), the forward button is disabled. It should be enabled. * After step (6), the browser is still at the top of the page (rather than at the "General" section, the URL bar does not say "#General", and the forward button is still enabled (it should be disabled) * Step (7) gives the same results as step (6). Looking at the text window makes me think the forward operation never completes. EXPECTED RESULTS: * After step (2), the "#General" should be in the URL bar * After step (3), the forward button should be enabled and should move forward to the "General" section (or somewhere else if the window was scrolled, but that doesn't work yet anyway...) * After step (6), the page should be at the "General" section (or elsewhere if the window was scrolled, etc. ...), and the forward button should be disabled DOES NOT WORK CORRECTLY ON: * Linux, apprunner, 1999-10-03-08-M11
Status: NEW → ASSIGNED
Target Milestone: M11
*** Bug 11629 has been marked as a duplicate of this bug. ***
My comment under DESCRIPTION about the forward button going "forward to the page without the named anchor" is incorrect. I realized it was incorrect and changed the ACTUAL BEHAVIOR section when I was writing the bug, but forgot to revise the DESCRIPTION. Hitting the forward button never completes. Here is the output in the text window after each of the steps in STEPS TO REPRODUCE: (1) Document http://www.fas.harvard.edu/~dbaron/links/Internet loaded successfully Document: Done (45.968 secs) failed to set the page title. (2) Document http://www.fas.harvard.edu/~dbaron/links/Internet#Architecture loaded successfully (3) Going Back Document http://www.fas.harvard.edu/~dbaron/links/Internet loaded successfully (4) Going Back Document http://www.fas.harvard.edu/~dbaron/ loaded successfully Document: Done (3.399 secs) (5) Going Forward Document http://www.fas.harvard.edu/~dbaron/links/Internet loaded successfully Document: Done (4.231 secs) (6) Going Forward (7) Going Forward
Note that going *back* to a named anchor works fine. The named anchor even shows up in the URL bar. (However, the next back does not remove the named anchor from the URL bar.) This means that there are probably two problems here: * back/forward doesn't update the URL bar when the only change is adding/removing a named anchor
* going forward to a named anchor doesn't work.
QA Contact: leger → claudius
The reason is a missing OnStartDocumentLoad notification when jumping to a anchor on the same document. The fix attached to bug 15315 fixes this too.
I saw the latest patches by andreas attached to bug # 15315. I intend to use the patch for EqualBaseURL()for this bug, 15605 and 11631. I have some modifications to the newly added OnStartDocument part. I'll get them reviewed and hopefully checked in today.
Fix checked in. Please verify
Status: RESOLVED → REOPENED
Reopening, this bug is only half-fixed now. I imagine this bug is 100%XP but I'm currently looking at the 1999111512 Linux build. Current Actual Behavior: I followed dbaron's above steps 1-6. Hitting 'Back' the first time yields no visible response. 'Going Back' is printed to the console. Hitting 'Back' a 2nd time takes you to current page -2. Clicking forward twice steps you through the correct pages even though the home page http://www.fas.harvard.edu/~dbaron/links/Internet was skipped on the way back. If that's not clear I'll be glad to show you but it does repro well.
Resolution: FIXED → ---
Clearing FIXED resolution due to reopen.
claudius...the 1999111512 Linux build was a M12 build. I need to know if this happens on any/all M11 builds ASAP.
Target Milestone: M11 → M12
moving to M12. Claudius will release note.
Status: REOPENED → ASSIGNED
Although it is very slow I don't see that behaviour on my build from 1999-11-15, it is just working as it should, with disableing the forward button after Step 6.
andreas, when you say it's very slow are you referring to a particular step? After step 3 for me nothing happens - I've waited a long time- still nothing happens. The main issue here is that the main page is skipped when going back from a named anchor. btw I reproduced this error in all M11 candidate builds: 1999111515-Mac, 1999111520-Linux, 1999111520-Win32 I've also reproduced it on the most current Mac build, 1999111608-m12
Whiteboard: RN
You are right, step 3 takes forever, I verifed that. I must have been impatient and hit Back again which led to the right page without loading the middle page. Somehow going back from a reference to the to of a document does sometimes not work. Sometimes it does. Really strange.
OS: Linux → All
Hardware: PC → All
Summary: problems going back/forward to named anchors → [dogfood]problems going back/forward to named anchors
For some reason going back in this case gives two identical URLs on the webshells involved, so nothing happens. But the current one should have the ref. If one forces the reload in nsSessionHistory::Load all works fine.
I havea fix for this. Iknow what regressed. Will be checking in soon.
Whiteboard: RN → [PDT-] RN
Marking PDT-, but check in the fix if you have it.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Fix checked in. Please verify.
Status: RESOLVED → VERIFIED
verified, all steps are ok using m12 candidate build
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.