Closed Bug 3152 Opened 26 years ago Closed 25 years ago

[Webshell] Reload on going back to new location on same document.

Categories

(Core Graveyard :: Embedding: APIs, defect, P2)

Product:
Core Graveyard
Component:
Embedding: APIs
Platform:
Other
Other
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: dbaron, Assigned: radha)

References

(
URL
)

Details

There are 2 problems with named anchors: clicking on back after clicking on a named anchor forces a reload, even though you're still within the same page. Also, (this is minor, though, I think) you're not scrolling horizontally to a named anchor. See: http://www.bath.ac.uk/%7Epy8ieh/internet/eviltests/anchor3.html
Also, the displayed URL isn't changing with the named anchors.
Nisheeth, the two Web Shell problems: - Back causes a reload of the document even when it's the same page - the location bar doesn't get updated when clicking on a named anchor Fixing both problems requires changing APIs a little
Assignee: troy → nisheeth
Status: NEW → ASSIGNED
Assigning bug to myself. I need to familiarize myself with the webshell code this week and looking at these bugs will be an ideal way to do it. Cool.
Target Milestone: M5
Setting milestone to M5...
Component: Layout → Embedding APIs
Setting component to Embedding APIs
Moving history and link clicking related problems to M6...
Moving non-crashing layout and webshell component bugs to M8... I already have enough blockers and crashers for M6. If I fix them in time for M6, I'll move some of these bugs back to the M6 milestone. I'm keeping the M7 milestone for fixing XML bugs.
Summary: named anchor problems → Reload on going back to new location on same document.
Two out of the three problems reported that are fixed in the M7 builds are: 1) We don't scroll horizontally to the named anchor 2) The location bar doesn't get updated when clicking on a named anchor. The one problem remaining is that we reload the document even when we go back to another location on the same document. Updating the summary to reflect that.
I have checked in a fix for the last remaining problem mentioned in my earlier update. On each URL load, the webshell tries to determine whether the new URL points to a location on the current document. If so, the webshell scrolls the document to the new location instead of reloading the document. I'll check this in today just as soon as I've talked to Troy about what is the best way to scroll a document to the top.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
I just checked in the fix.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Using 7/13 Apprunner, none of the three problems described appear to be fixed: (1) Clicking on 'Back' after clicking on a named anchor still forces a reload (tested with a large image) (2) Using the http://www.bath.ac.uk/%7Epy8ieh/internet/eviltests/anchor3.html example, browser does not go to target position (3) location bar does not get updated when clicking on a named anchor Reopening bug.
Status: REOPENED → ASSIGNED
Target Milestone: M8 → M9
Lets use this bug to track 1) in chrisd's post (07/15/99 11:53). Radha and me will look at 1) for M9. The reason this bug re-appeared is that the fix I put in caused problems like clicking in the location bar would not reload the page from netlib. I fixed that by creating a new reload type that will get used by history so that the webshell can differentiate between a load request from session history versus the location bar or other consumers. Now, all that needs to happen is for Radha to tell me the places in the history code where it makes sense to pass this paramter. I have opened two other bugs (9951, 9952) for problems 2) and 3). I am taking ownership of bug 9951 and Radha will own bug 9952.
Summary: Reload on going back to new location on same document. → [Webshell] Reload on going back to new location on same document.
Assignee: nisheeth → radha
Status: ASSIGNED → NEW
Re-assigning to Radha to pass in the new url reload type in the calls to nsWebShell::LoadURL().
Status: NEW → ASSIGNED
Accepting. Working on it.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Fix checked in. Please verify. The forward button doesn't enable when you go back from a anchor position to the top of the page. I know what the problem is there, but fix needs good amount of testing. So, I'm not going to do it now. The problem stated in this bug has been resolved. Please verify
Status: RESOLVED → VERIFIED
Using 8/5 Apprunner, verifying bug fixed in regards to the reload problem. The other two problems have been written up as separate bugs.
*** Bug 8224 has been marked as a duplicate of this bug. ***
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.