3152 - [Webshell] Reload on going back to new location on same document.

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There are 2 problems with named anchors:

clicking on back after clicking on a named anchor forces a reload, even though
you're still within the same page.

Also, (this is minor, though, I think) you're not scrolling horizontally to a
named anchor.  See:
http://www.bath.ac.uk/%7Epy8ieh/internet/eviltests/anchor3.html

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also, the displayed URL isn't changing with the named anchors.

Comment 2

[troy]

Nisheeth, the two Web Shell problems:
- Back causes a reload of the document even when it's the same page
- the location bar doesn't get updated when clicking on a named anchor

Fixing both problems requires changing APIs a little

Comment 3

[Nisheeth Ranjan]

Assigning bug to myself.  I need to familiarize myself with the webshell code
this week and looking at these bugs will be an ideal way to do it.  Cool.

Comment 4

[Nisheeth Ranjan]

Setting milestone to M5...

Comment 5

[Nisheeth Ranjan]

Setting component to Embedding APIs

Comment 6

[Nisheeth Ranjan]

Moving history and link clicking related problems to M6...

Comment 7

[Nisheeth Ranjan]

Moving non-crashing layout and webshell component bugs to M8...

I already have enough blockers and crashers for M6.  If I fix them in time for
M6, I'll move some of these bugs back to the M6 milestone.

I'm keeping the M7 milestone for fixing XML bugs.

Comment 8

[Nisheeth Ranjan]

Two out of the three problems reported that are fixed in the M7 builds are:

1) We don't scroll horizontally to the named anchor
2) The location bar doesn't get updated when clicking on a named anchor.

The one problem remaining is that we reload the document even when we go back to
another location on the same document.  Updating the summary to reflect that.

Comment 9

[Nisheeth Ranjan]

I have checked in a fix for the last remaining problem mentioned in my earlier
update.

On each URL load, the webshell tries to determine whether the new URL points to
a location on the current document.  If so, the webshell scrolls the document to
the new location instead of reloading the document.

I'll check this in today just as soon as I've talked to Troy about what is the
best way to scroll a document to the top.

Comment 10

[Nisheeth Ranjan]

I just checked in the fix.

Comment 11

[Christine Hoffman]

Using 7/13 Apprunner, none of the three problems described appear to be fixed:

(1) Clicking on 'Back' after clicking on a named anchor still forces a reload
(tested with a large image)
(2) Using the http://www.bath.ac.uk/%7Epy8ieh/internet/eviltests/anchor3.html
example, browser does not go to target position
(3) location bar does not get updated when clicking on a named anchor

Reopening bug.

Comment 12

[Nisheeth Ranjan]

Lets use this bug to track 1) in chrisd's post (07/15/99 11:53).  Radha and me
will look at 1) for M9.  The reason this bug re-appeared is that the fix I put
in caused problems like clicking in the location bar would not reload the page
from netlib.  I fixed that by creating a new reload type that will get used by
history so that the webshell can differentiate between a load request from
session history versus the location bar or other consumers.  Now, all that needs
to happen is for Radha to tell me the places in the history code where it makes
sense to pass this paramter.

I have opened two other bugs (9951, 9952) for problems 2) and 3).  I am taking
ownership of bug 9951 and Radha will own bug 9952.

Comment 13

[Nisheeth Ranjan]

Re-assigning to Radha to pass in the new url reload type in the calls to
nsWebShell::LoadURL().

Comment 14

[Radha on family leave (not reading bugmail)]

Accepting. Working on it.

Comment 15

[Radha on family leave (not reading bugmail)]

Fix checked in. Please verify. The forward button doesn't enable when you go
back from a anchor position to the top of the page. I know what the problem is
there, but fix needs good amount of testing. So, I'm not going to do it now.
The problem stated in this bug has been resolved. Please verify

Comment 16

[Christine Hoffman]

Using 8/5 Apprunner, verifying bug fixed in regards to the reload problem. The
other two problems have been written up as separate bugs.

Comment 17

[leger]

*** Bug 8224 has been marked as a duplicate of this bug. ***