1544214 - Not able to load yandex

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[37313]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Firefox nightly version since yesterday, 12.04.2019
If you type in address bar anything without prefix https:// or http:// then
"go to the address" or "search by word" does not happen - nothing happens at all.

if you type in addres bar like yandex.ru and press enter = nothing happens at all.
if you type in addres bar FULL address like https://yandex.ru and press enter = page loads normally.
And no word search at all

Actual results:

Nothing

Expected results:

go to the typed site or word search

Comment 1

[Marco Bonardo [:mak]]

Please try safe mode https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Also check you don't have userchrome.css or a chrome folder in your profile folder.

Comment 2

[37313]

In Firefox safe mode = same, nothing change, this error present.
userchrome.css = there is no file with such name

Marco Bonardo [::mak]
If you update Nightly right now, then you NOT SEEN this error?
RU, 64bit - Have you ever tried to reproduce this error?

Comment 3

[37313]

I tried install EN version Nightly = error disappear, but in search engines disappear also yandex!
I tried choose google search engine, then update RU version Nightly = error still present, see picture i add.

Comment 4

[37313]

Attachment: 11.jpg

Comment 5

[Alice0775 White]

I can reproduce this issue on ru build Nightly Build ID 20190413095252.

And the following error appear in Browser console:

getDefaultEngineInfo: No default engine SearchService.jsm:4195
getDefaultEngineInfo resource://gre/modules/SearchService.jsm:4195
InterpretGeneratorResume self-hosted:1286
AsyncFunctionThrow self-hosted:843
uncaught exception: 2147500037 3
2147500037 2 ContentSearch.jsm:364
_currentEventPromise resource:///modules/ContentSearch.jsm:364
InterpretGeneratorResume self-hosted:1286
AsyncFunctionThrow self-hosted:843

Comment 6

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c77962add953a48bdbcbbcd3d157d63d1267cd8e&tochange=a632dfa60af6edd4f7dd03d404d898b6222b56c3

Suspect: Bug 1496075

Comment 8

[V. Korn]

Ok, let me add to this bug, sicne i "had" similar problem. Actual ru locale is NOT needed (in my case). All you need to trigger is to in about:preferences - General - Languages add Russian language and make sure its on top of list. Restart and your browser is broken. Remove it from list or move it to bottom, restart and problem fixed.

Also, in my case i had significantly different errors in console:

Unable to initialize search service. PlacesSearchAutocompleteProvider.jsm:45
initialize resource://gre/modules/PlacesSearchAutocompleteProvider.jsm:45
AsyncFunctionThrow self-hosted:843

uncaught exception: 2147500037 UrlbarUtils.jsm:170:34

NS_ERROR_FAILURE: Failure'Failure' when calling method: [nsISearchService::getEngineByAlias] UrlbarUtils.jsm:170

Comment 9

[Pulse]

Just adding the this. I'm using the 'en-US' build of Nightly and starting yesterday all search engines were removed and the address bar became unusable. After restarting the browser again some search engines were added: Bing, DDG, Wikipedia, Google, Twitter and Amazon.

Yesterday, I readded my chosen search engines, primarily from Mycroft but also two two from AoM but once again, following the earlier update today, everything was reset.

I also have the 'Automatically update search engines' option unchecked.

Mozregression:

Bug 1496075 - Part 4: Delete searchplugins. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1a92c531a9af2815c1a8bb79716f0dd9d8b883a8&tochange=7e886806ae987d8008486c878921a8a33329c55b

Comment 11

[Mark Banner (:standard8)]

Just to acknowledge I've seen this. It is the weekend though, I'll try and have a look later today if someone doesn't beat me to it.

Comment 12

[Mark Banner (:standard8)]

Comment 9 is probably better handled in bug 1544273.

Here we'll just look at the non-en-US issues.

Comment 13

[Mark Banner (:standard8)]

I've just loaded the ru build with some more debugging information. I found this part:

_init: failure loading engines: Error: File resource://search-extensions/yandex-ru/ does not contain a valid manifest
loadManifest@resource://gre/modules/addons/XPIInstall.jsm:550:11
async*installBuiltinAddon@resource://gre/modules/addons/XPIInstall.jsm:3711:23
XPIProvider[meth]@resource://gre/modules/addons/XPIProvider.jsm:2888:28
installBuiltinAddon@resource://gre/modules/AddonManager.jsm:2056:33
installBuiltinAddon@resource://gre/modules/AddonManager.jsm:3379:33
_loadEngines@resource://gre/modules/SearchService.jsm:2918:30
async*_init@resource://gre/modules/SearchService.jsm:2646:18
async*init@resource://gre/modules/SearchService.jsm:3650:18
getDefault@resource://gre/modules/SearchService.jsm:4176:16
delayedStartupInit@chrome://browser/content/browser.js:3984:21
_delayedStartup@chrome://browser/content/browser.js:1634:19
EventListener.handleEvent*onLoad@chrome://browser/content/browser.js:1560:12
EventHandlerNonNull*@chrome://browser/content/browser.xul:104:39

This makes me believe there's two issues:

1. We don't fail gracefully if a single engine cannot be loaded. I think we should have a try/catch around this block.

2. resource://search-extensions/yandex-ru/ does not exist, but resource://search-extensions/yandex/ does.

I've not had time to look into this bit yet, but hopefully Dale knows what's happening here.

Comment 14

[Dale Harvey (:daleharvey)]

Ugh need to add yandex to https://searchfox.org/mozilla-central/source/toolkit/components/search/SearchService.jsm#178

Comment 15

[Dale Harvey (:daleharvey)]

Attachment: Bug 1544214 - Add Yandex to list of multi locale search extensions. r?standard8

Comment 16

[lolbrol]

I have the same problem.

I lost all my search engines since the update.

Can't add new search engines.

Adress bar doesn't work unless I type the full URL with HTTPS or HTTP. My adress bar is somehow also a searchbar!(seperated for a reason!!!)

Search bar doesn't work. I don't have search engines, obviously.

If I right click on a link the option to open the link in a new tab, new window or private window doesn't work. I also can't bookmark links. Sometimes I get the menu with way to many option, as if Firefox can't determine what I'm pointing on.

I don't use the English Firefox.

There are several people on firefox subreddit with the same problems.

Comment 17

[Dale Harvey (:daleharvey)]

I agree about the try catch, and I think we need new tests to ensure we catch this before, but I might not be able to write them until tomorrow so put the fix up sans tests for now

Comment 18

[Mark Banner (:standard8)]

(In reply to lolbrol from comment #16)

I have the same problem.

I expect this will affect people in the following locales: az, be, kk, ru, tr. Regions related to those may be affected. Hopefully this will be fixed in one of the next two nightlies.

(In reply to Dale Harvey (:daleharvey) from comment #17)

I agree about the try catch, and I think we need new tests to ensure we catch this before, but I might not be able to write them until tomorrow so put the fix up sans tests for now

Yes, good idea. I think some of this is also going to be covered by the unit testing that we're writing soon, but it'd still be good to have a specific test for this fallback (hence marking as leave-open for now).

I've submitted the patch to Lando so it should land soon. I'll see if there's any Sheriffs around to see if we can get it into the next nightly.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fde3dab694e
Add Yandex to list of multi locale search extensions. r=Standard8

Comment 20

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3fde3dab694e

Comment 21

[Pulse]

Although my earlier comment was marked as off topic, I should point out that I'm in the RU region. I just happen to use the en-US version of Nightly. I also delete Yandex.

Comment 22

[lolbrol]

I'm using the Dutch version in Belgium(BE). The problem is fixed. Other locales still may be affected of course.

Thanks for the quick fix.

Comment 23

[Dale Harvey (:daleharvey)]

Attachment: Bug 1544214 - Ensure all engines in list.json can be loaded. r?Standard8

Comment 24

[Dale Harvey (:daleharvey)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=26b8347fab084c9b4ddf5c6da2cbf1d28b018371

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e07782ebf0f2
Ensure all engines in list.json can be loaded. r=Standard8

Comment 26

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e07782ebf0f2