1544392 - Yandex logo missing in search preferences

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Selim Şumlu]

Attachment: preferences-yandex-logo.jpg

Yandex logo is missing in default search engine and one-click search engines preferences.

I'm using the Turkish locale so the search engine is yandex-tr. I'm not sure if thid affects other Yandex locales.

Comment 1

[37313]

RU locale = Yandex logo is missing too.

Comment 2

[Mark Banner (:standard8)]

This will be any Yandex locale. I just saw this go past in debugging:

icons: Object { 16: "moz-extension://73c04a9e-a8a3-8f43-9d4e-06cc411898c1/__MSG_extensionIcon__" }

So I'm guessing replacing the extension icon isn't supported in the way we're trying to do it.

https://searchfox.org/mozilla-central/search?q=extensionIcon&case=false&regexp=false&path=search

Comment 3

[Mark Banner (:standard8)]

Shane, I'm guessing this isn't something that WebExtensions currently support. Any suggestions on the best way forward? Could we add the facility of this to them?

Comment 4

[Shane Caraveo (:mixedpuppy)]

Any property that needs to be localizable needs ["preprocess": "localize"] in the schema.

Try that.

https://searchfox.org/mozilla-central/rev/d302c3058330a57f238be4062fddea629311ce66/toolkit/components/extensions/schemas/manifest.json#410

Comment 5

[Mark Banner (:standard8)]

The patch I'm just about to attach will fix the search icon, but will only show up in new profiles. Existing profiles won't see it until the next nightly version bump (or the cache is invalidated for some reason, e.g. a location change).

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1544392 - Allow extension icons to be supplied from localized manifest properties, and fix the Yandex icon in search engines. r?mixedpuppy

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2a0278aa9ec
Allow extension icons to be supplied from localized manifest properties, and fix the Yandex icon in search engines. r=mixedpuppy

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c2a0278aa9ec