Closed Bug 1544392 Opened 7 months ago Closed 7 months ago

Yandex logo missing in search preferences

Categories

(Firefox :: Search, defect, P1)

defect
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 68
Iteration:
68.3 - Apr 15 - 28
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 + fixed

People

(Reporter: selim, Assigned: standard8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Yandex logo is missing in default search engine and one-click search engines preferences.

I'm using the Turkish locale so the search engine is yandex-tr. I'm not sure if thid affects other Yandex locales.

Component: Preferences → Search
Regressions: 1544214

RU locale = Yandex logo is missing too.

Priority: -- → P1
Regressions: 1496075
No longer regressions: 1544214
Regressed by: 1496075
No longer regressions: 1496075

This will be any Yandex locale. I just saw this go past in debugging:

icons: Object { 16: "moz-extension://73c04a9e-a8a3-8f43-9d4e-06cc411898c1/__MSG_extensionIcon__" }

So I'm guessing replacing the extension icon isn't supported in the way we're trying to do it.

https://searchfox.org/mozilla-central/search?q=extensionIcon&case=false&regexp=false&path=search

Shane, I'm guessing this isn't something that WebExtensions currently support. Any suggestions on the best way forward? Could we add the facility of this to them?

Flags: needinfo?(mixedpuppy)

Any property that needs to be localizable needs ["preprocess": "localize"] in the schema.

Try that.

https://searchfox.org/mozilla-central/rev/d302c3058330a57f238be4062fddea629311ce66/toolkit/components/extensions/schemas/manifest.json#410

Flags: needinfo?(mixedpuppy)
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Iteration: --- → 68.3 - Apr 15 - 28
Points: --- → 3

The patch I'm just about to attach will fix the search icon, but will only show up in new profiles. Existing profiles won't see it until the next nightly version bump (or the cache is invalidated for some reason, e.g. a location change).

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2a0278aa9ec
Allow extension icons to be supplied from localized manifest properties, and fix the Yandex icon in search engines. r=mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.