Closed Bug 1544468 Opened 5 years ago Closed 5 years ago

Reduce the number of IPC calls on nsISHEntry in nsSHistory::SetChildHistoryEntry

Categories

(Core :: DOM: Navigation, task, P2)

Product:
Core
Component:
DOM: Navigation
Type:
task

Tracking

()

Status:
RESOLVED INVALID
Project Flags:
Fission Milestone M4
Tracking Flags:
Tracking Status
firefox69 --- wontfix

People

(Reporter: annyG, Assigned: annyG)

References

(Blocks 1 open bug)

Details

With session history state being moved into the parent, static method nsSHistory::SetChildHistoryEntry, called from nsDocShell::SetHistoryEntry, will be running in the child process. nsDocShell::SetHistoryEntry contains many IPC calls to nsISHEntry such as calls to nsISHEntry::GetChildAt in a loop [1], among others.

[1] https://searchfox.org/mozilla-central/rev/0376cbf447efa16922c550da3bfd783b916e35d3/docshell/shistory/nsSHistory.cpp#521

Type: defect → enhancement
Depends on: 1546759
Depends on: 1546762
No longer depends on: 1546762
Fission Milestone: --- → M3
Type: enhancement → task
Priority: -- → P2
Fission Milestone: M3 → M4

This will no longer be necessary because as a result of Bug 1546759 this method will be called from a parent process and the aforementioned calls will no longer go over IPC.

status-firefox69: --- → wontfix
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Depends on: 1579093
No longer depends on: 1579093
You need to log in before you can comment on or make changes to this bug.