1579093 - Fix failing test docshell/test/navigation/test_load_history_entry.html on ash

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Anny Gakhokidze [:annyG]]

Fix failing test docshell/test/navigation/test_load_history_entry.html as seen here https://treeherder.mozilla.org/#/jobs?repo=ash&selectedJob=264938202

Comment 1

[Anny Gakhokidze [:annyG]]

My initial speculation is that it is failing because of recent changes to session history in bug https://bugzilla.mozilla.org/show_bug.cgi?id=1563587. My test was assuming certain things about navigations that might no longer be valid.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Step 2 seems to leak hashchange event to step 3 occasionally. That is racy because of setTimeout(,0) usage in the test.

Comment 3

[Anny Gakhokidze [:annyG]]

Thank you for taking a look! You mentioned doing something like this

await clickLink(testWin, "link2");
+ await new Promise((r) => setTimeout(r));
await doAfterEachTest(testWin, shistory, numSHEntries, previousLocation);

fixes the test. Is this considered a hack and I should change how the test is written or is this considered to be an acceptable? :D

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

That is considered a hack. It was just for debugging.
Unless I haven't made some mistake, the previous step should just wait for hashchange event too.

Comment 5

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1579093 - Fix failing test docshell/test/navigation/test_load_history_entry.html on ash,

Comment 6

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1579093 - Fix failing test docshell/test/navigation/test_load_history_entry.html on ash,

Comment 7

[Neha Kochar [:neha]]

Landed in ash branch - https://hg.mozilla.org/projects/ash/rev/2353562bc8aa7330ee6dfae16c25b9023d8598f6

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfd20e536b85
Fix failing test docshell/test/navigation/test_load_history_entry.html on ash, r=smaug

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dfd20e536b85