1545023 - Crash in [@ mozilla::net::LoadInfo::LoadInfo]

Status: RESOLVED FIXED

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-38cbb461-b358-463c-a76a-d7dde0190417.

Top 10 frames of crashing thread:

0 xul.dll mozilla::net::LoadInfo::LoadInfo netwerk/base/LoadInfo.cpp:290
1 xul.dll nsresult mozilla::net::nsIOService::NewChannelFromURIWithProxyFlagsInternal netwerk/base/nsIOService.cpp:907
2 xul.dll nsresult mozilla::net::nsIOService::NewChannelFromURIWithClientAndController netwerk/base/nsIOService.cpp:868
3 xul.dll NS_NewChannelInternal netwerk/base/nsNetUtil.cpp:370
4 xul.dll NS_NewChannel netwerk/base/nsNetUtil.cpp:313
5 xul.dll void mozilla::net::nsHttpChannel::PerformBackgroundCacheRevalidationNow netwerk/protocol/http/nsHttpChannel.cpp:10318
6 xul.dll nsresult mozilla::detail::RunnableMethodImpl<mozilla::net::nsHttpChannel*, void  xpcom/threads/nsThreadUtils.h:1174
7 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1180
8 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486
9 xul.dll void mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:88

There are 18 crashes (from 11 installations) in nightly 68 with buildid 20190416220148. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1536511.

[1] https://hg.mozilla.org/mozilla-central/rev?node=728aa342ad35

Comment 1

[Sören Hentzschel]

Crash report from macOS 10.11.6:
https://crash-stats.mozilla.org/report/index/a0983ea3-45db-4931-94cb-8b5cd0190417

Firefox crashes every time when trying to load https://www.ghacks.net. I wasn't able to reproduce the crash on other websites.

Comment 2

[Honza Bambas (:mayhemer)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=75b9130a472c3f7c42f7807a67c171b3a1fe72df

Comment 3

[Honza Bambas (:mayhemer)]

Attachment: Bug 1545023 - Use more proper function for creating the background revalidation channel to prevent assertion failures and crashes, r=bzbarsky

Comment 4

[Andrew McCreight [:mccr8]]

[Tracking Requested - why for this release]: #1 non-shutdown hang crash on Windows for the 3/17 Nightlies.

Comment 7

[Julian Seward [:jseward]]

This is the #2 topcrash in the Windows nightly 20190418221600,
with 82 crashes from what looks like a significantly large number
of different installations.

Comment 8

[Intermittent Failures Robot]

1 failures in 2673 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows10-64-ux: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1545023&startday=2019-04-15&endday=2019-04-21&tree=all

Comment 9

[mdew]

Seems to rather major bug, maybe commit in 1536511 should be reverted?

Comment 10

[Julien Cristau [:jcristau]]

Boris, it'd be great to have this reviewed and fixed asap. Thanks!

Comment 11

[Calixte Denizet (:calixte)]

The patch in bug 1536511 has been backed out.

Comment 12

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Sorry for the lag here; I was out most of last week...

Comment 13

[Daniel Holbert [:dholbert]]

(In reply to Calixte Denizet (:calixte) from comment #11)

The patch in bug 1536511 has been backed out.

How sure are we that this fixed the crash? I just hit this crash in the latest nightly [EDIT: turns out I wasn't running latest nightly, sorry for my confusion]
bp-d4e3019b-f1af-4afa-8221-9d4e20190423
bp-e1d1dc02-c3dc-4af2-847a-1d7d20190423

My STR:
(1) Visit https://imgur.com/gallery/dSYAaEb
(2) Save the page in Pocket (click the pocket icon at right edge of URLbar)
(3) Visit https://app.getpocket.com/ and click the new tile that you just created there ("tl;dw Game of Thrones Season 8, Episode 2 Recap - Album on Imgur")

Results:
crash [@ mozilla::net::LoadInfo::LoadInfo ], see bp-*** report links above.

Comment 14

[Calixte Denizet (:calixte)]

:dholbert, the first report has buildid 20190418221600 and the second 20190417214729 and the first build with the backout is 20190422214919.
Fyi, if you've a look on the crash table on the top of this page, you can see that builds after 20190422214919 (included) don't have (at least for now) any crashes with this signature.

Comment 15

[Daniel Holbert [:dholbert]]

Ah, thank you & sorry for my confusion/false-alarm. Indeed, latest nightly doesn't crash after all, with my STR.

(In comment 13, I had only verified that I was on latest nightly [via Help|About] after I'd crashed twice -- and it seems I'd been initially running an old build, with an old-update staged to install, which is why I was still on an old version in my second crash. Each post-crash browser-restart got me a tick closer to the latest version.)