1545788 - more eval() fun: Assertion failure: false (do not use eval with system privileges), at /builds/worker/workspace/build/src/dom/security/nsContentSecurityManager.cpp:205

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

https://taskcluster-artifacts.net/VxU3emuIQkynPCtAmd0KMg/0/public/logs/live_backing.log

INFO -  TEST-START | /Users/cltbld/tasks/task_1555676294/build/tests/mozmill/attachment/test-attachment.js | test_attachment_name_click
INFO -  [891, Main Thread] WARNING: '!ClientIsValidPrincipalInfo(mClientInfo.PrincipalInfo())', file /builds/worker/workspace/build/src/dom/clients/manager/ClientSource.cpp, line 169
INFO -  ++DOMWINDOW == 101 (0x1315f6000) [pid = 891] [serial = 179] [outer = 0x129615f20]
INFO -  [891, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/workspace/build/src/parser/html/nsHtml5StreamParser.cpp, line 1026
INFO -  [891, Main Thread] WARNING: '!ClientIsValidPrincipalInfo(mClientInfo.PrincipalInfo())', file /builds/worker/workspace/build/src/dom/clients/manager/ClientSource.cpp, line 169
INFO -  JavaScript error: chrome://mozmill/content/modules/utils.jsm, line 329: uncaught exception: 2153578497
INFO -  ++DOCSHELL 0x12d63c800 == 34 [pid = 891] [id = {35e8f511-83f2-af40-98ef-406c270d0b97}]
INFO -  ++DOMWINDOW == 102 (0x12c1b2200) [pid = 891] [serial = 180] [outer = 0x0]
INFO -  ++DOMWINDOW == 103 (0x1315f8400) [pid = 891] [serial = 181] [outer = 0x12c1b2200]
INFO -  [891, Main Thread] WARNING: NS_ENSURE_TRUE(root) failed: file /builds/worker/workspace/build/src/layout/base/nsDocumentViewer.cpp, line 3123
INFO -  Assertion failure: false (do not use eval with system privileges), at /builds/worker/workspace/build/src/dom/security/nsContentSecurityManager.cpp:205

Looks like bug 1541858 which landed in the last merge. Stuff was also added to the whitelist there:
https://hg.mozilla.org/mozilla-central/rev/5be51df44c5c#l3.71
https://hg.mozilla.org/mozilla-central/rev/5be51df44c5c#l5.13

simpletest/testrunner.js,simpletest/simpletest.js,file_bug1018265.xul,helperappdlg.jsm,test_execute_async_script.py

Do we use any of that?

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1545788-helperappdlg-jsm.patch

OK, helperappdlg.jsm needed to be added.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5461dc8b5555
Port bug 1541858: Add helperappdlg.jsm to whitelist in security.uris_using_eval_with_system_principal. rs=bustage-fix DONTBUILD