1546051 - Picture-in-picture switch displayed on Netflix previews

Status: VERIFIED FIXED

(Web Compatibility :: Interventions, task, P1)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot

Currently the blue switch for PiP appears on Netflix previews, and overlaps with the rating controls.

If selected, it also seems to trigger a click on the preview, starting the movie. But it doesn't seem to happen all the time.

Ideally, it shouldn't be displayed on this type of content at all.

Comment 1

[Adam Stevenson [:adamopenweb]]

I am able to reproduce this. Doesn't seem to happen on all previews. But if you do click on the PiP for a preview, and close PiP, you could end up with a video playing in the background.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

It's difficult for us to programmatically detect that this is a Netflix preview, unless we hard code in something to let us identify them. Perhaps that's something we could do with a WebCompat intervention?

Comment 3

[Adam Stevenson [:adamopenweb]]

I think we could scope some CSS, to disable the toggle, to the https://www.netflix.com/browse page.

:miketaylr - would you be comfortable with using the webcompat system add-on to hide the PiP toggle on the Netflix browse page?

Comment 4

[Mike Taylor [:miketaylr]]

Adam, yeah -- presumably this won't be an intervention we ship forever (should we coordinate w/ Netflix?).

Any pointers on how we can write this intervention? Is there some magic class we should be looking for?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Making it possible / easy for a WebExtension (even one with experiment-capabilities like WebCompat) to modify the position of the toggle wasn't part of the original design, so I'll have to come up with something.

So I think it's on me to figure out how to write the intervention (and then I'll probably just write it myself, but get someone on the WebCompat team to review it for me).

Comment 6

[Mike Taylor [:miketaylr]]

That works! Will keep an eye out for PRs to https://github.com/mozilla/webcompat-addon.

Comment 7

[Cristian Craciun]

Build ID 20191124230652
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:72.0) Gecko/20100101 Firefox/72.0

Reproducible also on Nightly 72 on macOS 10.13 platform.

Comment 8

[Timea Cernea [:tbabos][inactive]]

Reproducible on Nightly 74 and Beta 73.

Comment 9

[Mike Taylor [:miketaylr]]

I think we have the ability to fix this now:

https://searchfox.org/mozilla-central/source/toolkit/components/pictureinpicture/PictureInPictureTogglePolicy.jsm#14

Comment 10

[Marcela (Please NI request to Brindusa Tot)]

Reproducible on latest Nightly 77.0a1 (2020-04-29) on MacOS 10.14

Comment 11

[Mike Taylor [:miketaylr]]

Fixed by https://hg.mozilla.org/mozilla-central/rev/bb2d9b53ac6e

Comment 12

[Daniel Bodea [:danibodea]]

I have verified this fix in Nightly v100.0a1 on Windows 10, Ubuntu 22 and Mac OS 11.
The PiP toggle does not appear on preview videos (on the https://www.netflix.com/browse page).