1527925 - Enable user-initiated Picture in Picture for video by default on Nightly for Windows

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, enhancement, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

This means setting media.videocontrols.picture-in-picture.enabled to true.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1527925 - Enable User-Initiated Picture-in-Picture on Windows, Nightly-only. r?jaws

Depends on D27806

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1527925 - Make browser_contextmenu.js work with or without Picture-in-Picture enabled by default. r?jaws

Depends on D27951

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d418d95454eb
Make browser_contextmenu.js work with or without Picture-in-Picture enabled by default. r=jaws
https://hg.mozilla.org/integration/autoland/rev/a55e5c83e32e
Enable User-Initiated Picture-in-Picture on Windows, Nightly-only. r=jaws

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8515e58392b7
Backed out 4 changesets (bug 1527925, bug 1545168, bug 1539567) for failing at /actions/test_media.html on a CLOSED TREE.

Comment 5

[Raul Gurzau (:RaulG)]

Backed out 4 changesets (bug 1527925, bug 1545168, bug 1539567) for failing at /actions/test_media.html on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8515e58392b724460b731fe12881de75a2397c0a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=241082928&revision=f5273f8e51966ff5d45588bfcd1826a5642ba8b4

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=241082928&repo=autoland&lineNumber=1347

Log snippet:

01:50:44 INFO - Invoke the 'invoke an action press at index undefined on ['button@id="pictureInPictureToggleButton" node', address: [object HTMLButtonElement], role: pushbutton, address: 0x1a291700]' test { scenario #0: expected 'name changed' event; }
01:50:44 INFO - TEST-PASS | accessible/tests/mochitest/actions/test_media.html | No actions on the accessible for ['button@id="pictureInPictureToggleButton" node', address: [object HTMLButtonElement], role: pushbutton, address: 0x1a291700]
01:50:44 INFO - TEST-PASS | accessible/tests/mochitest/actions/test_media.html | Wrong action name of the accessible for ['button@id="pictureInPictureToggleButton" node', address: [object HTMLButtonElement], role: pushbutton, address: 0x1a291700]
01:50:44 INFO - Buffered messages finished
01:50:44 INFO - TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/actions/test_media.html | Test timed out.
01:50:44 INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:275:18
01:50:44 INFO - reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:22
01:50:44 INFO - TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:142:7
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - TestRunner.runTests/<@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:381:20
01:50:44 INFO - promise callbackTestRunner.runTests@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:368:50
01:50:44 INFO - RunSet.runtests@chrome://mochikit/content/tests/SimpleTest/setup.js:201:14
01:50:44 INFO - RunSet.runall@chrome://mochikit/content/tests/SimpleTest/setup.js:180:12
01:50:44 INFO - hookupTests@chrome://mochikit/content/tests/SimpleTest/setup.js:273:12
01:50:44 INFO - parseTestManifest@chrome://mochikit/content/manifestLibrary.js:38:5
01:50:44 INFO - getTestManifest/req.onload@chrome://mochikit/content/manifestLibrary.js:49:11
01:50:44 INFO - EventHandlerNonNullgetTestManifest@chrome://mochikit/content/manifestLibrary.js:45:3
01:50:44 INFO - hookup@chrome://mochikit/content/tests/SimpleTest/setup.js:253:5
01:50:44 INFO - linkAndHookup@chrome://mochikit/content/harness.xul:45:3
01:50:44 INFO - parseTestManifest@chrome://mochikit/content/manifestLibrary.js:38:5
01:50:44 INFO - getTestManifest/req.onload@chrome://mochikit/content/manifestLibrary.js:49:11
01:50:44 INFO - EventHandlerNonNullgetTestManifest@chrome://mochikit/content/manifestLibrary.js:45:3
01:50:44 INFO - getTestList@chrome://mochikit/content/chrome-harness.js:251:3
01:50:44 INFO - loadTests@chrome://mochikit/content/harness.xul:24:3

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dbd2a962bcf
Make browser_contextmenu.js work with or without Picture-in-Picture enabled by default. r=jaws
https://hg.mozilla.org/integration/autoland/rev/7cad4b1dec5a
Enable User-Initiated Picture-in-Picture on Windows, Nightly-only. r=jaws

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/4dbd2a962bcf
https://hg.mozilla.org/mozilla-central/rev/7cad4b1dec5a

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Could we add that to our nightly release notes?

Comment 9

[Mike Conley (:mconley) (:⚙️)]

(In reply to Pascal Chevrel:pascalc from comment #8)

Could we add that to our nightly release notes?

Sure!

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Note added to nightly notes with this wording:

User Initiated Picture-in-Picture has been enabled by default on Nightly on Windows

Comment 11

[Eric Shepherd [:sheppy]]

As far as I can tell, there's nothing developer-facing here. If there is, I can't find it. Given that, I'm inclined to leave the documentation alone and at most mention the change in the developer notes.

Comment 12

[Chris Mills [:cmills]]

This is only in Nightly for now anyway, so removing dev-doc-needed