Closed Bug 1546667 Opened 5 years ago Closed 5 years ago

Remove checkin-needed keyword from BMO

Categories

(bugzilla.mozilla.org :: Administration, task)

Product:
bugzilla.mozilla.org
Component:
Administration
Version:
Production
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: smacleod, Unassigned)

References

Details

We'll want to remove the checkin-needed keyword from Bugzilla once the process has been migrated to Phabricator.

When will this be completed?

Are we keeping it from being set for bugs in the future, or are we removing it from existing bugs as well?

Flags: needinfo?(smacleod)

(In reply to Emma Humphries, Bugmaster ☕️🎸🧞‍♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me from comment #1)

When will this be completed?

The process will be migrated to Phabricator in 1 to 2 weeks. The idea would be to remove it from bugzilla immediately after.

Are we keeping it from being set for bugs in the future, or are we removing it from existing bugs as well?

Preventing it from being set in the future. Although, it really shouldn't be on any bugs a short time after it is disabled, since those requests should be handled in a short time frame.

Flags: needinfo?(smacleod)

Okay, please NI me when this is migrated so I can disable the keyword.

Depends on: 1555712

The Thunderbird team is using this keyword on a daily basis. Also, there are cases where Phabricator/Lando don't work. In this case, the keyword is also needed. See bug 1576146.

Since our priority is supporting the Phabricator/Lando workflow, and re-enabling the keyword can lead to confusion, I don't want to permanently

But we can provide you a thunderbird-checkin-needed keyword and move your existing bugs which use the checkin-needed keyword to that.

Flags: needinfo?(jorgk)

OK, maybe shorter? checkin-needed-tb or so. No need for "migration", there will only be a few at any given time.

But how do we notify sheriffs in case Phab/Lando don't work, see bug 1576146? Do I really have to pull the Mozilla repository and push it myself?

BTW, somewhat unrelated: Are all voluntary Mozilla contributors equipped with what it needs to do Phab? Or did they get lost in the process? When I started here some five years ago, attaching a patch was all that was required, anyone could do that. You've significantly raised the bar for casual contributors.

Flags: needinfo?(jorgk)

Jorg, I'll create that keyword for you.

Contacting the sheriffs on IRC would be probably be the right thing. I'll ping aryx.

The switch to Phabricator was done to address deficiencies engineering leadership had with our review process.

Flags: needinfo?(aryx.bugmail)

Yes, I'm in contact with the sheriffs constantly. That said, they're still doing a round of running their own "checkin-needed" query, so eventually they'll have to stop doing so.

Actually, we have processes that remove the checkin-needed keyword when a patch is pushed for the bug. That needs to be changed, too.

I submitted a pull request for Pulsebot at https://github.com/glandium/pulsebot/pull/27

The pull request referenced in comment 10 is now deployed on pulsebot.

I guess so. In the meantime sending patches Phab also has been made to work for us (using hg phabsend), so we don't need the keyword any more. In edge cases, I'll talk to the sheriffs.

Flags: needinfo?(jorgk)

Is the checkin-needed-tb flag needed still?

Flags: needinfo?(aryx.bugmail) → needinfo?(jorgk)

Yes, of course. You created that one as a replacement. Our developers set this keyword and the I (the sheriff) land the patches. We don't use Lando and we also bundle patches for landing ... and we don't have an "inbound" intermediary repository.

Flags: needinfo?(jorgk)

I am now at a loss as to how to get my patches landed. Could you please update https://wiki.mozilla.org/Phabricator/FAQ#Lando to describe the new procedure?

Hmm, that's what I wrote in comment #6:

Are all voluntary Mozilla contributors equipped with what it needs to do Phab? Or did they get lost in the process? When I started here some five years ago, attaching a patch was all that was required, anyone could do that. You've significantly raised the bar for casual contributors.

As far as I know, landing a patch via Lando requires Level 3 access rights. And voluntary contributors won't have those.

Yeah, I don't have Level 3 access, and Bugzilla won't let me add the checkin-needed keyword anymore. So what's the procedure now? I guess I'm supposed to ask whoever reviews my patches to land them for me too?

(In reply to Alex Henrie from comment #18)

Yeah, I don't have Level 3 access, and Bugzilla won't let me add the checkin-needed keyword anymore. So what's the procedure now? I guess I'm supposed to ask whoever reviews my patches to land them for me too?

Thank you for bringing this up.

My understanding is that your reviewer is supposed to push to try to confirm the patch and then merge it, and I need to verify that. I'm checking with Sherffs for confirmation and will make sure the docs are updated.

Quick update. Sheriffs are watching a query in Phabricator for checkins to the tree. I'm looking for where there's a public interface to watch that queue, or see the progress of your patch, because once the patch is reviewed, it'd be good to see that status in the bug.

Thanks for the link! So there's a "Check-in Needed" tag that I can add to my revision on Phabricator, and then it is automatically checked in. Great!

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.