Closed Bug 1546768 Opened 8 months ago Closed 8 months ago

Design fixes for Special FXA snippet

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 68
Iteration:
68.3 - Apr 15 - 28
Tracking Status
firefox67 --- fixed
firefox68 --- verified

People

(Reporter: rrosario, Assigned: rrosario)

References

Details

(Keywords: github-merged)

Attachments

(1 file)

:wolasi did a design review and requested the following changes:

Snippet Top and Bottom Margins

.below-search-snippet
margin-top: -14px;
margin-bottom: 16px;

Fx icon

size: 24px x 24px
margin-top: 12px
margin-top: 16px for narrowest breakpoint

Text

.SimpleBelowSearchSnippet .body
margin: 12px 0;

Link
font-weight: 600;

Dismiss Button
top: 24px;

Narrowest width, snippet should be in a card container as shown in spec

Blocks: 1546808
Status: NEW → RESOLVED
Closed: 8 months ago
Keywords: github-merged
Resolution: --- → FIXED

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190429215338) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the FxA snippet respects the specs from comment 0.

Status: RESOLVED → VERIFIED
Blocks: 1548042
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.