1547699 - improvements/simplifications for MozAttachmentlist

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1523607 +++

This is the followup to bug 1523607 comment 53

Comment 1

[Jorg K (CEST = GMT+2)]

... and bug 1523607 comment 63 and bug 1523607 comment 64.

Comment 2

[Arshad Khan [:arshad]]

ALso fix Bug 1554943 and Bug 1552965.

Comment 3

[Arshad Khan [:arshad]]

Attachment: attachmentListImprovements.patch

Fixes Bug 1554943, Bug 1552965 and https://bugzilla.mozilla.org/show_bug.cgi?id=1547699#c1

Comment 4

[Arshad Khan [:arshad]]

target.matches error is not fixed yet.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9068884 [details] [diff] [review]
attachmentListImprovements.patch

Review of attachment 9068884 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to work, and try is happy - https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c2e4cbe9650b6e90e5a73b303c9694994a802293

It would have been preferable to do each issue in their own dedicated bug. But...

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9068884 [details] [diff] [review]
attachmentListImprovements.patch

And this needs beta uplift so the various problems get fixed there as well.

Comment 7

[Jorg K (CEST = GMT+2)]

(In reply to Arshad Khan [:arshad] from comment #3)

Fixes Bug 1554943, Bug 1552965 and https://bugzilla.mozilla.org/show_bug.cgi?id=1547699#c1

Yes, I verified that the two bugs are fixed. The issue from bug 1523607 comment #64 is not fixed, I still get:

JavaScript error: chrome://messenger/content/messengercompose/MsgComposeCommands.js, line 5825: TypeError: target.matches is not a function

and an attachment still can't be dragged to after the last item to it becomes the last item.

Comment 8

[Magnus Melin [:mkmelin]]

Yes, but better to do that in a separate bug.

Comment 9

[Arshad Khan [:arshad]]

This bug needs a rebase if Bug 1556122 is pushed first.

Comment 10

[Jorg K (CEST = GMT+2)]

Sure, already lined up for landing.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d14d6540a92
Improvements/Simplifications for MozAttachmentlist. r=mkmelin

Comment 12

[Jorg K (CEST = GMT+2)]

TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/06327efa8b67bd2c793b8aedca893cdf45ccaf89