1556192 - Problems when dragging attachments: TypeError: target.matches is not a function

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1547699 +++
+++ This bug was initially created as a clone of Bug #1523607 +++

This is the follow-up to bug 1547699 comment 7:

Dragging attachments in the attachment bucket gives:

JavaScript error: chrome://messenger/content/messengercompose/MsgComposeCommands.js, line 5825: TypeError: target.matches is not a function

Also, an attachment still can't be dragged to after the last item to it becomes the last item.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1556192-target-matches-1.diff

I broke this fixing bustage in bug 1513110. The root of the problem is a function which could return an element or a string.

Comment 2

[Jorg K (CEST = GMT+2)]

Does this fix the "can't drag after last" issue?

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9069845 [details] [diff] [review]
1556192-target-matches-1.diff

It does, thanks!

Comment 4

[Magnus Melin [:mkmelin]]

(In reply to Geoff Lankow (:darktrojan) from comment #1)

I broke this fixing bustage in bug 1513110. The root of the problem is a
function which could return an element or a string.

Which function? If in c-c let's fix that.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cc7e364a2504
Check attachment bucket target in onDragOver and onDrop before using .matches. r=jorgk

Comment 6

[Jorg K (CEST = GMT+2)]

The breaking change is this:
https://searchfox.org/comm-central/diff/15a2f2b33d87abbdd40b9fd81070bbf18c48ecab/mail/components/compose/content/MsgComposeCommands.js#5758

And the function is _adjustDropTarget() here:
https://searchfox.org/comm-central/rev/66bdc4565824a8c59d34ba88c3d8e70448356a71/mail/components/compose/content/MsgComposeCommands.js#5720

Personally, I wouln't mess with it.

Comment 7

[Jorg K (CEST = GMT+2)]

TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/48b8729fef6766e716c0ea26e9d7ed0f57c86775