1547792 - intrinsic ratio should be represented by a single ratio, not a size.

Status: RESOLVED FIXED

(Core :: Layout, task, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

An aspect ratio is a number, not a size, and should be represented as such.

This simplifies potential implementation of an aspect-ratio CSS property, and also ensures that an empty aspect-ratio is always treated as such, even if one of its dimensions is non-empty, which also matches other browsers reading their usage of aspect ratio (they represent the aspect ratio with a size, but always check whether it's not empty before using it).

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1547792 - AspectRatio should be a single ratio, not a size. r=dholbert

Comment 2

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5273f436120e775cb7ac9d3934e59e803daba438

So green :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/451701e88d92
AspectRatio should be a single ratio, not a size. r=dholbert

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/451701e88d92