Open Bug 1548768 Opened 6 years ago Updated 2 years ago

Missing test coverage for intrinsic ratio in vertical writing-mode

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

People

(Reporter: emilio, Unassigned)

References

Details

In bug 1547792, Daniel spotted two errors in my patch related to vertical writing-mode that didn't make any test fail:

  • Making this call IsRowOriented rather than IsMainAxisHorizontal.
  • Making this line be just auto logicalRatio = aIntrinsicRatio;.

Should both have caused test failures.

Adding bug 1547231 to the see also list so I'm less likely to completely forget.

Priority: -- → P3

Is this test coverage still missing?

Flags: needinfo?(emilio)

Yes

Flags: needinfo?(emilio)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.