Closed Bug 1548056 Opened 5 years ago Closed 3 years ago

Stop using FrameLayerBuilder for painting filters in blob grouping code

Categories

(Core :: Graphics: WebRender, task, P3)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: jrmuizel, Assigned: mattwoodrow)

References

(Regressed 3 open bugs)

Details

Attachments

(2 files)

Currently Grouper::PaintContainerItem uses a BasicLayerManager to paint filters. We basically just need to call nsFilterInstance::PaintFilteredFrame() which doesn't rely on a LayerManager.

Type: defect → task
Priority: -- → P3
Blocks: 1540737

We'll also need to do some work to make sure the paint rect is set appropriately. Though maybe it would be better to not have a paint rect at all...

Assignee: nobody → matt.woodrow
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9849809643a6
Use nsDisplayItem::Paint for filters and transforms within SVG blobs instead of FrameLayerBuilder. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/c1a29b263709
Use nsDisplayItem::Paint and DLBI to paint fallback filters instead of FrameLayerBuilder. r=jrmuizel
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Regressions: 1712491
Regressions: 1714596
Regressions: 1720986
Regressions: 1795553
Regressions: 1813318
Regressions: 1846910
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: