1714596 - crash on https://pro.ant.design/

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[709922234]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

visit https://pro.ant.design/

Actual results:

crash!

Comment 1

[Peter Magyari (Desktop QA)]

I was able to reproduce the issue on Nightly 91.0a1 and Beta 90.0b3 however, the issue does not occur on Firefox 89.0
Also, the issue only occurs when Webrender is enabled.

I've ran a mozregression and it returned the following Bug 1548056 as the culprit.

I'm setting the component in order to involve the development team in reviewing this issue.

Thank you for reporting!

Comment 2

[Jamie Nicol [:jnicol]]

This is also an guaranteed crash for me on Linux: https://crash-stats.mozilla.org/report/index/b1a8134e-ddb0-489e-aa9b-4e2fe0210608

Matt, are you able to investigate the cause? cc Andrew too as he fixed another regression from bug 1548056

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1714596 - Don't try to create a temporary DrawTarget for zero-sized blend modes. r?jrmuizel

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/002ed6224559
Don't try to create a temporary DrawTarget for zero-sized blend modes. r=jrmuizel

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/002ed6224559

Comment 6

[Peter Magyari (Desktop QA)]

I have verified the fix on Nightly 91.0a1 (20210615214502)

Comment 7

[Julien Cristau [:jcristau]]

Please request beta uplift when you get a chance.

Comment 8

[Julien Cristau [:jcristau]]

Jeff do you think this is worth uplifting to 90?

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Yep.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9226672 [details]
Bug 1714596 - Don't try to create a temporary DrawTarget for zero-sized blend modes. r?jrmuizel

Beta/Release Uplift Approval Request

• User impact if declined: Crashes on some web content that does zero sized blending. We seem to have fairly high volume so probably worth fixing
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pretty low risk. The patch is simple and there's not much that could go wrong.
• String changes made/needed:

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9226672 [details]
Bug 1714596 - Don't try to create a temporary DrawTarget for zero-sized blend modes. r?jrmuizel

approved for 90.0b11

Comment 12

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dc866fd81c6c

Comment 13

[Peter Magyari (Desktop QA)]

I have verified the fix on Beta 90.0b11 (20210622185930)