Add a checkbox in prefs to enable/disable password generation
Categories
(Toolkit :: Password Manager, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | verified |
People
(Reporter: MattN, Assigned: sfoster)
References
(Blocks 1 open bug)
Details
(Whiteboard: [passwords:generation] [skyline])
User Story
If the password manager is unchecked in preferences, the password generation checkbox should be disabled to reflect that they work together. The generation checkbox should probably be indented underneath it. If `signon.generation.available` is false then the checkbox should be hidden altogether.
Attachments
(2 files, 1 obsolete file)
about:preferences#privacy Password Generation Checkbox
Users need a way to enable/disable password generation
|
Reporter | |
Updated•5 years ago
|
|
|
Reporter | |
Comment 1•5 years ago
|
||
This is blocked on getting copy for the checkbox label.
|
|
Reporter | |
Comment 2•5 years ago
|
||
Hi Betsy,
My understanding is that you will be helping with copy for password generation. Could you please review the string for the new checkbox? it will turn on/off whether generated passwords will be offered to the user in the autocomplete popup on a password field. I think the checkbox should be nested under the "Remember logins and passwords for sites" checkbox since it will only work if that is also on… that does cause an issue with the "Saved Logins…" button placement though…
I think the "new accounts" aspect of the proposed string from the mock isn't great since we will also generate passwords on password change forms which are for existing accounts.
Thank you
|
||
Comment 3•5 years ago
|
||
String should read: Suggest and generate strong passwords.
Here's a rough mock-up to show what all the final strings should look like together, since the previous screenshot pre-dates some other string changes.
|
|
||
Comment 4•5 years ago
|
||
|
|
Reporter | |
Comment 5•5 years ago
|
||
Thank you Betsy!
|
|
Reporter | |
Updated•5 years ago
|
|
|
Reporter | |
Updated•5 years ago
|
|
|
Reporter | |
Updated•5 years ago
|
|
Assignee | |
Comment 6•5 years ago
|
||
- Add password generation checkbox as child of savePasswords checkbox
- Shuffle layout to put the Exceptions and Saved Logins buttons in a right-column
- Fix browser_site_login_exceptions.js which apparently relies on signon.rememberSignons being false
- No changes related to bug 1550142 in this patch
|
||
Updated•5 years ago
|
|
|
Reporter | |
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56d2a86214e1 Add UI for the password generation preferences. r=MattN,flod,fluent-reviewers
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
|
||
Comment 9•5 years ago
|
||
Is there another bug for shipping this default on or default off in 70/Skyline?
|
|
Reporter | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 10•5 years ago
|
||
(In reply to Liz Henry (:lizzard) (use needinfo) from comment #9)
Is there another bug for shipping this default on or default off in 70/Skyline?
We're turning on both prefs by default in bug 1565407.
|
||
Comment 11•5 years ago
|
||
Addition confirmed with 69.0b7 on Windows 10, macOS 10.14, Ubuntu 18.04.
Option marked as: Suggest and generate strong passwords.
Description
•