1548522 - Remove support for the menclose's "radical" notation

Status: RESOLVED FIXED

(Core :: MathML, task)

Description

[Frédéric Wang Nélar]

The MathML CG agrees to drop it from MathML Core, it duplicates the <msqrt> element and is not used in practice: https://github.com/mathml-refresh/mathml/issues/3#issuecomment-475507647

Comment 1

[Frédéric Wang Nélar]

Attachment: data-collection-mathml-menclose-radical-notation.txt

Comment 2

[Frédéric Wang Nélar]

Attachment: Bug 1548522 - Remove support for the menclose's "radical" notation. r=emilio

See https://groups.google.com/forum/#!topic/mozilla.dev.platform/vwAkuZIEhnY

This is WIP, I think handling of invalid values is not clear in the core spec.
See https://github.com/mathml-refresh/mathml/issues/144

• Introduce a new preference option to disable menclose's "radical" notation.
• Disable the notation in Nightly and when running WPT tests.
• Enable the notation in other channels together with a counter and
  deprecation warning.
• Remove failure expectation for WPT test legacy-menclose-radical-notation.html
• Enable the radical notation for MathML reftests testing it.

Comment 3

[Ben Miroglio [:bmiroglio]]

Comment on attachment 9094441 [details]
data-collection-mathml-menclose-radical-notation.txt

# Data Review Form 

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way? (see [here](https://github.com/mozilla/activity-stream/blob/master/docs/v2-system-addon/data_dictionary.md), [here](https://github.com/mozilla-mobile/focus/wiki/Install-and-event-tracking-with-the-Adjust-SDK), and [here](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/index.html) for examples).  Refer to the appendix for "documentation" if more detail about documentation standards is needed.

This will be documented in the [probe dictionary](https://telemetry.mozilla.org/probe-dictionary/).

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, this can be turned off in Firefox Preferences.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

This is not permanent, although there's the potential for renewal. :fredw is responsible should a renewal be necessary.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1: Technical Data

5) Is the data collection request for default-on or default-off?

default-on

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice? 

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data? 

Yes. In 6 months :fredw should check in.

9) Does the data collection use a third-party collection tool? **If yes, escalate to legal.**

No.

data-review: r+

Comment 4

[Frédéric Wang Nélar]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd7168dc20eb27e516b9caa4f05e54179ea393bf

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2613eaa1369
Remove support for the menclose's "radical" notation. r=emilio

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/19495 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d5b29ee19f3
Backed out changeset d2613eaa1369 for reftest failures on legacy-menclose-radical-notation.html.

Comment 10

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=d2613eaa13690e3771e84ef6ff5080a8fa348a66&searchStr=reftest&selectedJob=269669575

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269669445&repo=autoland&lineNumber=51748

Backout link: https://hg.mozilla.org/integration/autoland/rev/8d5b29ee19f3

Comment 11

[Frédéric Wang Nélar]

mmh, I don't understand why it was not caught by the try server. But the first menclose of legacy-menclose-radical-notation-ref.html should be <menclose notation="">

Comment 12

[Frédéric Wang Nélar]

(In reply to Frédéric Wang (:fredw) from comment #11)

mmh, I don't understand why it was not caught by the try server. But the first menclose of legacy-menclose-radical-notation-ref.html should be <menclose notation="">

mmh, this was even written in the commit message. Not sure how I overlooked it.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d734cb4e0ca
Remove support for the menclose's "radical" notation. r=emilio

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 15

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6d734cb4e0ca

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 17

[Kohei Yoshino [:kohei]]

Posted site compatibility note: https://www.fxsitecompat.dev/en-CA/docs/2019/various-legacy-mathml-features-have-been-deprecated/

Comment 18

[Florian Scholz (Open Web Docs)]

Updated https://developer.mozilla.org/en-US/docs/Web/MathML/Element/menclose

Please add 'dev-doc-needed' to the bug that removes this in a stable Firefox version.