1549418 - Implement Web Authentication FIDO2 support in GeckoView

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[J.C. Jones [:jcj] (he/they)]

Implement Web Authentication via com.google.android.gms:play-services-fido. This is going to involving moving the code from https://phabricator.services.mozilla.com/D1148 (bug 1391438) to more permanent locations and adjusting to match the GV architecture.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

I think the basic strategy here would be to add a method to GeckoSession.ContentDelegate or perhaps a new delegate. Something like:

class WebAuthnCredential {
    byte[] clientDataJson;
    byte[] keyHandle;
    byte[] attestationObject;
}

GeckoResult<WebAuthnCredential> onWebAuthnMakeCredential(String rpId, String rpName, String rpIcon,
                                                         ByteBuffer userId, String userName,
                                                         String userIcon, String userDisplayName,
                                                         final ByteBuffer challenge, long timeoutMs,
                                                         String origin, final Object[] idList,
                                                         final ByteBuffer transportList);

We would then let Android Components and/or Fenix handle all the nitty gritty of interacting with Play Services.

Comment 2

[Chris Peterson [:cpeterson]]

Adding [geckoview:fenix:p2] whiteboard tag because we'd like WebAuthn support in Fenix soon, but it's not a release blocker for Fenix MVP.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Pulsebot from bug 1391438 comment #9)

https://hg.mozilla.org/integration/autoland/rev/d8e0bfeb5fa3
Support FIDO2 for WebAuthn on Android r=snorp,keeler

J.C., does the FIDO2 patch for bug 1391438 also fix this bug?

Comment 4

[J.C. Jones [:jcj] (he/they)]

As far as I understand it, no. It's most of the way, though, but the landed modules from bug 1391438 need to move to different locations for g-v / a-c.

Comment 5

[Chris Peterson [:cpeterson]]

Bug 1555425 enabled WebAuthn for Fennec 68, but specifically excluded GeckoView. Once Google whitelists Fenix for WebAuthn, we should enable WebAuthn for GeckoView.

Comment 6

[J.C. Jones [:jcj] (he/they)]

Whitelisting is expected "June/July". Will update when I hear it's done.

That said, I think the code refactoring could happen anytime in mozilla-central.

Comment 7

[Chris Peterson [:cpeterson]]

Deferring this bug from Fenix's M7 (July) milestone to the M8 backlog for later in Q3.

Comment 8

[Chris Peterson [:cpeterson]]

I'm editing a bunch of GeckoView bugs. If you'd like to filter all this bugmail, search and destroy emails containing this UUID:

e88a5094-0fc0-4b7c-b7c5-aef00a11dbc9

Comment 9

[Chris Peterson [:cpeterson]]

Fenix's WebAuthn issue: https://github.com/mozilla-mobile/fenix/issues/1340

Comment 10

[Jonathan Almeida [:jonalmeida]]

Removing closed (invalid) issue.

Comment 11

[Chris Peterson [:cpeterson]]

Bumping from milestone M8 to M9 because the Fenix issue is in Fenix's Q4 backlog:

https://github.com/mozilla-mobile/fenix/issues/1340

Comment 12

[J.C. Jones [:jcj] (he/they)]

(In reply to J.C. Jones [:jcj] (he/him) from comment #6)

Whitelisting is expected "June/July". Will update when I hear it's done.

I didn't think to ping until now, but the Android team has confirmed this is done and ready-to-go.

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to James Willcox (:snorp) ([e-mail]) (he/him) from comment #1)

I think the basic strategy here would be to add a method to GeckoSession.ContentDelegate or perhaps a new delegate. Something like:

class WebAuthnCredential {
    byte[] clientDataJson;
    byte[] keyHandle;
    byte[] attestationObject;
}

GeckoResult<WebAuthnCredential> onWebAuthnMakeCredential(String rpId, String rpName, String rpIcon,
                                                         ByteBuffer userId, String userName,
                                                         String userIcon, String userDisplayName,
                                                         final ByteBuffer challenge, long timeoutMs,
                                                         String origin, final Object[] idList,
                                                         final ByteBuffer transportList);

The billion arguments should obviously be captured inside some kind of WebAuthnRequest class :)

Comment 15

[Henri Sivonen (:hsivonen)]

Shouldn't this rank higher in type and severity? AFAICT, right now, if a user has adopted WebAuthn in Fennec, they get locked out of their accounts when they get the Fenix upgrade, which is alread rolling out.

Comment 16

[Eldridge Alexander]

In particular this prevents anyone using Google's Advanced Protection setting to use FF on mobile.

Comment 17

[James Willcox (:snorp) ([e-mail]) (he/him)]

Yeah, I think we need to get on this. I'm clearing priority so we'll retriage.

Comment 18

[J.C. Jones [:jcj] (he/they)]

Thanks, :snorp.

Comment 19

[Amedyne Moya [:amoya]]

Will handle most of this in GV.

Comment 20

[James Willcox (:snorp) ([e-mail]) (he/him)]

I'm working on this now, hopefully will have something up this week. It will be trivial for Android Components to consume this, as they'll just need to launch the FIDO intent and collect the result.

Comment 21

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1549418 - Add GeckoRuntime.ActivityDelegate

This allows GeckoView to ask the embedding application to launch
other Activities on our behalf and collect the result. We need
this to invoke the FIDO authentication tools for WebAuthn.

Comment 22

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1549418 - Hook up WebAuthn support for GeckoView

This mostly just refactors the stuff we had for Fennec.

We add a dependency on Google Play Services here, but care
is taken to ensure that things will fail gracefully if
Play Services are not present at runtime.

Comment 23

[Henri Sivonen (:hsivonen)]

For uplift consideration: When Firefox has taken over the kinds of in-app browser views that Firefox can take over from Chrome, if the user tries to sign into Hey with a security key, the flow fails.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb3cee345d37
Add GeckoRuntime.ActivityDelegate r=geckoview-reviewers,agi,esawin
https://hg.mozilla.org/integration/autoland/rev/b2c7cf464308
Hook up WebAuthn support for GeckoView r=geckoview-reviewers,jcj,agi

Comment 25

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bb3cee345d37
https://hg.mozilla.org/mozilla-central/rev/b2c7cf464308

Comment 26

[Cristian Brindusan [:cbrindusan]]

Backed out 2 changesets (Bug 1549418) for causing android bpgo exceptions.
https://hg.mozilla.org/integration/autoland/rev/b114812f82755c9d0254d9b4d0b13478f0020822

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=b2c7cf46430823457190dded0323f73eaf870992&selectedTaskRun=DvbzQKKFSKyYJy3KhArvEg.5

Failure log:
https://firefox-ci-tc.services.mozilla.com/tasks/DvbzQKKFSKyYJy3KhArvEg/runs/5/logs/https%3A%2F%2Ffirefox-ci-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FDvbzQKKFSKyYJy3KhArvEg%2Fruns%2F5%2Fartifacts%2Fpublic%2Flogs%2Flive.log

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3d44f363444
Add GeckoRuntime.ActivityDelegate r=geckoview-reviewers,agi,esawin
https://hg.mozilla.org/integration/autoland/rev/93743d0782aa
Hook up WebAuthn support for GeckoView r=geckoview-reviewers,jcj,agi

Comment 28

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d3d44f363444
https://hg.mozilla.org/mozilla-central/rev/93743d0782aa