Closed Bug 1549438 Opened 6 years ago Closed 11 months ago

[meta] Emulation.setTouchEmulationEnabled

Categories

(Remote Protocol :: CDP, task)

Product:
Remote Protocol
Component:
CDP
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: ato, Unassigned)

References

(
URL
)

Details

(Keywords: meta, Whiteboard: [method=Emulation.setTouchEmulationEnabled])

No description provided.
Blocks: puppeteer
URL: https://chromedevtools.github.io/devt...
Keywords: meta
Whiteboard: [method=Emulation.setTouchEmulationEnabled]
Whiteboard: [method=Emulation.setTouchEmulationEnabled] → [puppeteer-alpha]
Whiteboard: [puppeteer-alpha] → [puppeteer-alpha] [method=Emulation.setTouchEmulationEnabled]

This API is part of Puppeteer's EmulationManager.emulateViewport() method, which is at least in use by Page.setViewport(). This latter method is in use for screenshots specifically, or when creating an instance of a Page with a defaultViewport.

While it doesn't seem to be directly used with Gutenberg the logs contain a not that small number of instances:

636 Emulation.setTouchEmulationEnabled

I have no idea where those are coming from. So it might need a bit more investigation.

Beside that we clearly need it for puppeteer-examples, where the screenshots rely on it.

Btw Juggler uses the following code here:

docShell.touchEventsOverride = hasTouch ? Ci.nsIDocShell.TOUCHEVENTS_OVERRIDE_ENABLED : Ci.nsIDocShell.TOUCHEVENTS_OVERRIDE_NONE;
No longer blocks: puppeteer-gutenberg, puppeteer-examples
Whiteboard: [puppeteer-alpha] [method=Emulation.setTouchEmulationEnabled] → [method=Emulation.setTouchEmulationEnabled]
Component: CDP: Emulation → CDP
Severity: normal → S3

All that we could do for this API has been done.

Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.