1549559 - Avoid copies of shape data all over the place.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Right now if you have a big SVG path, we copy the path to every element that match.

I want to add bindings for Arc<[Slice]> (effectively ThinArc<>), and this is a good test bed.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Not-yet-cleaned-up try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d514e5c58e3035fed1458d52d5889e614743756c

Comment 2

[Boris Chiou [:boris]]

Cool. Thanks.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1549559 - Introduce ArcSlice, a small wrapper over ThinArc but without an explicit header. r=heycam

We could make the header PhantomData or something, but then we wouldn't be able
to bind to C++, since C++ doesn't have ZSTs. So add a canary instead to add a
runtime check of stuff being sane.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1549559 - Add bindings for ArcSlice and ThinArc, and use them to reduce copies of SVG path data. r=heycam

As I said over bug 1549593, the eventual goal is to use ArcSlice in all
inherited properties. But this seemed like a good first candidate that doesn't
require me to move around a lot more code, since we were already using cbindgen
for the path commands.

Depends on D30133

Comment 5

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d90d1f6c15fe02b83056318e7f804e22ea4f9ff is green :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc57611c4e71
Introduce ArcSlice, a small wrapper over ThinArc but without an explicit header. r=heycam
https://hg.mozilla.org/integration/autoland/rev/51a7edbe0a9e
Add bindings for ArcSlice and ThinArc, and use them to reduce copies of SVG path data. r=heycam

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/dc57611c4e71
https://hg.mozilla.org/mozilla-central/rev/51a7edbe0a9e