Avoid copies of shape data all over the place.
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files)
Right now if you have a big SVG path, we copy the path to every element that match.
I want to add bindings for Arc<[Slice]> (effectively ThinArc<>), and this is a good test bed.
|
Assignee | |
Comment 1•5 years ago
|
||
Not-yet-cleaned-up try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d514e5c58e3035fed1458d52d5889e614743756c
|
||
Comment 2•5 years ago
|
||
Cool. Thanks.
|
|
Assignee | |
Comment 3•5 years ago
|
||
We could make the header PhantomData or something, but then we wouldn't be able
to bind to C++, since C++ doesn't have ZSTs. So add a canary instead to add a
runtime check of stuff being sane.
|
|
Assignee | |
Comment 4•5 years ago
|
||
As I said over bug 1549593, the eventual goal is to use ArcSlice in all
inherited properties. But this seemed like a good first candidate that doesn't
require me to move around a lot more code, since we were already using cbindgen
for the path commands.
Depends on D30133
|
|
Assignee | |
Comment 5•5 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dc57611c4e71 Introduce ArcSlice, a small wrapper over ThinArc but without an explicit header. r=heycam https://hg.mozilla.org/integration/autoland/rev/51a7edbe0a9e Add bindings for ArcSlice and ThinArc, and use them to reduce copies of SVG path data. r=heycam
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dc57611c4e71
https://hg.mozilla.org/mozilla-central/rev/51a7edbe0a9e
Description
•