1549637 - Homepage link on the global header is wrong

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Kohei Yoshino]

STR:

1. Open the Enter Bug page
2. Click the Bugzilla homepage on the global header

Expected: It takes you to the homepage

Actual: The page reloads.

Culprit:

<a href="[% c.url_for('/home').to_abs FILTER html %]" title="Go to home page">

Side note: The announcement banner hidden on another page also appears.

Maybe enter_bug.cgi is not under control of Mojolicious?

Comment 1

[Dylan Hardison [:dylan] (he/him)]

  if (($ENV{SERVER_SOFTWARE} // '') eq 'Bugzilla::App::CGI') {
    $vars->{self} = $vars->{c} = $Bugzilla::App::CGI::C;
  }

Something is probably overwriting 'c'. I hate this template language so much, I wish everything was just mojo's template language (which is just perl but prevents this sort of footgun)

Comment 2

[Kohei Yoshino]

Ah okay, found the culprit. Then this is a variant of Bug 1514275.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: GitHub Pull Request

Comment 4

[Kohei Yoshino]

Merged to master.