1549727 - The page shifts slightly to the left after dismissing the onboarding modal

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

[Affected versions]:

• Firefox Nightly 68.0a1, Build ID 20190507094727

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Steps to reproduce]:

1. Start the browser with a new profile and navigate to about:welcome.
2. Observe the page as you dismiss the modal.

[Expected results]:

• The page remains in the same place.

[Actual results]:

• The page shifts slightly to the left after the modal is dismissed.

[Notes]:

• It looks like this is related to the fact that while the modal is displayed the page does not have a scrollbar. And when the modal is dismissed the page has a scrollbar and this moves all the elements to the left.
• The issue is also reproducible with the "sync" modal.
• Attached a screen recording of the issue: Link.

Comment 1

[Tim Spurway [:tspurway]]

aaron, what

Comment 2

[Ed Lee :Mardak]

In bug 1549714, our fix changed height breakpoint to 760px and width breakpoint to 924px to show scrollbars (and push the modal up slightly). Given that those breakpoints seem somewhat large, should we just always allow the page to be scrolled (and maybe remove the "push up modal" behavior) ?

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

UX/Aaron gave us the go to always be scrolling.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5005

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/d94d1e2c6f43

Comment 6

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible on the latest Nightly 68.0a1 (Build ID 20190509033505) on Windows 10x64, Mac 10.14, and Arch Linux 4.14.3.

Comment 7

[Ed Lee :Mardak]

Marking verified as per bug 1550098 Comment 13 for bugs that were status-firefox68=verified