Closed Bug 155025 Opened 22 years ago Closed 22 years ago

Installer rearranges desktop icons on first run

Categories

(SeaMonkey :: Installer, defect, P1)

Product:
SeaMonkey
Component:
Installer
Platform:
x86
Windows XP
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: ed, Assigned: ssu0262)

References

Details

(Whiteboard: [adt2 RTM])

Attachments

(1 file)

patch v1.0
5.80 KB, patch
Details | Diff | Splinter Review 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1a+) Gecko/20020629
BuildID:    2002062908

After installing (with default options), when the installer runs the new
instance of Mozilla, at the time the splash screen is first displayed, all
desktop icons are rearranged down the LHS of the desktop. (as when one
right-clicks on the desktop and chooses Arrange Icons By->Name)

Reproducible: Always
Steps to Reproduce:
1.Install Mozilla from today's nightly build

I think this is new to the last few nightly builds; certainly 1.0 and Alpha
don't cause this to occur.

This occurs irrespective of whether there already is a Mozilla shortcut on the
desktop.
The icons should have refreshed, but we're not doing any rearranging.

Can anyone else repro this?
Assignee: dveditz → curt
155169 is a duplicate of this bug - I hope that counts as confirmation :)
reporter, can you try this:

* download the mozilla installer and save into an empty dir
* run mozilla-win32-installer.exe -u
* edit config.ini in this same dir:
    make sure that the following is set to FALSE:
    [General]
    Refresh Icons=FALSE

* save this file
* run setup.exe

If it does *not* rearrange the icons, then it looks like the problem is with the
refresh code under XP.  Instead of just refreshing the icons, it'll rearrange
them :(

*** Bug 155169 has been marked as a duplicate of this bug. ***
confirming based on multiple reports
Status: UNCONFIRMED → NEW
Ever confirmed: true
re Comment #3:

I followed the above instructions with mozilla-win32-installer-sea.exe build
2002070112 (which I previously observed to cause this bug).

After changing the line in config.ini to Refresh Icons=FALSE, windows did *not*
rearrange the desktop icons.

It looks like Sean is correct on what's causing this.
In Bug 155169 Comment #2, dveditz@netscape.com said:

> Could this be a side effect of the icon cache rebuild? I'm not seeing it on Win2K

I think this is quite likely to be the case - if I rebuild the icon cache, from
TweakUI say, then the desktop gets rearranged exactly as happens in this bug.
Yeah, definitely seeing this in the past 2 builds (at least), but not before
then.  Builds 07/01  and  06/29  were the only builds I am _sure_ this has
happened on. (I never tried build 06/30).

To note, this has only been a recent change, as I have been running XP since
November 2001, and have not noticed the problem until now.

I indeed have WinXP. Not sure if this is a change in XP, or a change in Mozilla.
 There have been multiple patches (critical updates and such) that may have
changed the way XP refreshes (unlikely, but entirely possible).

Reporter (Ed), have you updated Windows (either automatically or manually) lately?
A small update.  I removed 3 of the 4 updates since June 26th that I updated on
my system.  

After each removal.. I restarted my computer, and re-installed mozilla.  The
rearranging was still present.

The three HotFixes I was able to remove:
Q320678
Q320552
Q320174

The 4th HotFix cannot be removed from XP.. Which I downloaded/installed the 27th
of June:
Q320920: Security Update (Windows Media Player for Windows XP)

I am less convinced the Windows Updates (HotFixes) have anything to do with this
bug.  If it _does_, it would be relating to the WMPlayer update, which I could
not uninstall.

Right-Clicking desktop, and using the "Refresh" command will _not_ re-organize
desktop icons in the manner described.

I ran the installer using different options.. (such as with QuickLaunch
enabled.. and without, etc)

It is surely an icon cache rebuild. ALl the icons vanish.. re-appear with
'generic' icons, then return to their 'real' icons.

58 icons on my desktop.. a pain to re-organize ;) I'll gladly do more testing,
if needed.
So I also had to reinstall the software last night with the latest build, and
the icons refreshed once again.  However, at home is a WinXP machine.  At work
here, I am running Win2k, and the icons have never refreshed.  Maybe this will
help?!?
Although this is probably known already, this doesn't happen on Win98SE. Also, I
doubt it happens on Win ME either (although I have no proof of that, just an
educated guess).
Thanks for all the input everyone.  I know what's causing this now and am
working on a fix.
Assignee: curt → ssu
*** Bug 155452 has been marked as a duplicate of this bug. ***
Attached patch patch v1.0 — — Splinter Review 
This is a preliminary patch, but is better than the one for bug 154708.  That
patch refreshed the entire desktop icons, while this one, only refreshes the
shortcuts that we created.

I haven't tested this patch under win9x, but works great under win2k.

The only draw back is that it does not work under WinXP.  I don't know why. 
Could be a problem with XP itself...?  But in any case, I think that not
refreshing the icons under XP is much better than refreshing and rearranging
them at the same time.
*** Bug 155975 has been marked as a duplicate of this bug. ***
adding nsbeta1 keyword.  rearranging user's icons on the desktop is not a good
thing.  There doesn't look like a workaround that can fix this without the bad
side affect.

I recommend either taking the new patch, which works under win2k but does not
under winXP, or just fixing the current code to not be triggered under WinXP.

Actually, if we take the new patch, we need to make sure that it works with all
of Win2k's service packs.  The advantage of this new patch is that it doesn't
make all the desktop icons disappear then reappear.  It only refreshes the ones
we touch/create.
Status: NEW → ASSIGNED
Keywords: nsbeta1
*** Bug 156439 has been marked as a duplicate of this bug. ***
Do we really need to update the desktop icons? Won't any new icon show up 
automatically by itself?
*** Bug 156642 has been marked as a duplicate of this bug. ***
*** Bug 157226 has been marked as a duplicate of this bug. ***
changing priority and severity to get some attention.
Severity: normal → critical
Priority: -- → P1
This isn't a crash. Mail to drivers/adt to get attention, don't abuse the
severity field which they don't look at anyway (boy do we need a "visibility"
field, though).
Severity: critical → normal
Keywords: adt1.0.1
Win98SE Mozilla Build 2002071508

Icons not re-arranged but does refresh all desktop icons as well as those in the
quickstart bar.

To add some more detail to Comment #23 based on my observations.

Yes, under Win98SE the icons are refreshed, but not rearranged. However, I've
noticed that the icons are refreshed multiple times (well, at least twice, I
haven't actually counted).
I really think the XP problem should be fixed for 1.1 as it is a pain in the 
butt. I'm sure you programmer guys have your own favourites, but from an end 
user point of view this is really annoying!
Any program that, when installed, makes a mess of the users working environment
is being severely arrogant. Just imagine if someone rearranged your desk at work
every day, I bet you wouldn't like that. This falls into the same category. 

I think this bug should be NSBETA1+ and ADT1.0.0+ and ADT1.0.1+.
this problem is fixed now due to patch to bug 154708.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
verified with branch build mozilla - 2002072206-10
and trunk build mozilla-2002072208 on XP
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → gbush
Keywords: verified1.0.1
Blocks: 143047
Keywords: adt1.0.1 → adt1.0.1+
Whiteboard: [adt2 RTM]
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: