1550554 - Use OwnedSlice / ArcSlice and such even more.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1550554 - Implement ArcSlice::default(). r=heycam

Share a singleton to avoid allocating for empty lists.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1550554 - Use an ArcSlice as the computed value representation of inherited list properties. r=heycam

This adds a bit of complexity, which I think will pay off in the end. Removals
incoming.

Depends on D30543

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1550554 - Share computed and specified value representation of -moz-context-properties. r=heycam

Depends on D30544

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1550554 - Use ArcSlice for quotes. r=heycam

This saves the intermediate allocation.

Depends on D30545

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1550554 - Add bindings for box shadows, and remove nsCSSShadowArray and friends. r=heycam

Depends on D30546

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1550554 - Use OwnedSlice for will-change. r=heycam

We could use ArcSlice if wanted I guess, your call. Though will change is not
supposed to be used very frequently.

Depends on D30547

Comment 7

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3eb549775d6bc956d84b974f9b8f775b01f4f13f, fwiw

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45f171b26e95
Implement ArcSlice::default(). r=heycam
https://hg.mozilla.org/integration/autoland/rev/57f2362aa538
Use an ArcSlice as the computed value representation of inherited list properties. r=heycam
https://hg.mozilla.org/integration/autoland/rev/2c31fe18eefd
Share computed and specified value representation of -moz-context-properties. r=heycam
https://hg.mozilla.org/integration/autoland/rev/b28a48e2ed21
Use ArcSlice for quotes. r=heycam
https://hg.mozilla.org/integration/autoland/rev/882ab9868c95
Add bindings for box shadows, and remove nsCSSShadowArray and friends. r=heycam
https://hg.mozilla.org/integration/autoland/rev/b90c2cf5b8c5
Use OwnedSlice for will-change. r=heycam

Comment 9

[Andrei Ciure[:aciure]]

Backed out 17 changesets (bug 1550554, bug 1549593, bug 1551991, bug 1529002) for failing multiple Android tests and Windows 2012 bustages

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=35f91a9ea82af8ba15ea08996149bb871d6957f8

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=2a9a034e1b6a38cba33ba668704cce7ad7a04cd3&selectedJob=246819809&searchStr=android%2C4.3%2Capi16%2B%2Cdebug%2Ctest-android-em-4.3-arm7-api-16%2Fdebug-geckoview-junit-e10s-1%2C%28gv-junit1%29

win2012 bustages: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=2a9a034e1b6a38cba33ba668704cce7ad7a04cd3&selectedJob=246815110&searchStr=windows%2C2012%2Caarch64%2Cdebug%2Cbuild-win64-aarch64%2Fdebug%2C%28b%29

backout: https://hg.mozilla.org/integration/autoland/rev/283b94c196a15367f287fd7f2bb6c9b4bcad0b45

Comment 10

[Alexandru Michis [:malexandru]]

New failure "Assertion failure: _0.ptr->data.header.header == kArcSliceCanary (Uh?), at z:/build/build/src/obj-firefox/dist/include\mozilla/ServoStyleConstsInlines.h:118"

Failure link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246826943&repo=autoland&lineNumber=993

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Yeah, the ArcSlice::default() sharing was busted for 32-bit builds, that's a bit of a shame :-)

I'll re-land with it fixed.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c2ff6058888
Implement ArcSlice::default(). r=heycam
https://hg.mozilla.org/integration/autoland/rev/6524a34864c3
Use an ArcSlice as the computed value representation of inherited list properties. r=heycam
https://hg.mozilla.org/integration/autoland/rev/79010ce706eb
Share computed and specified value representation of -moz-context-properties. r=heycam
https://hg.mozilla.org/integration/autoland/rev/1e32fe8538ed
Use ArcSlice for quotes. r=heycam
https://hg.mozilla.org/integration/autoland/rev/9efd6e065be9
Add bindings for box shadows, and remove nsCSSShadowArray and friends. r=heycam
https://hg.mozilla.org/integration/autoland/rev/d0e6717d1cf0
Use OwnedSlice for will-change. r=heycam

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7c2ff6058888
https://hg.mozilla.org/mozilla-central/rev/6524a34864c3
https://hg.mozilla.org/mozilla-central/rev/79010ce706eb
https://hg.mozilla.org/mozilla-central/rev/1e32fe8538ed
https://hg.mozilla.org/mozilla-central/rev/9efd6e065be9
https://hg.mozilla.org/mozilla-central/rev/d0e6717d1cf0