1551991 - Remove nsCSSValue bindings from the style system.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1551991 - Remove legacy transform interpolation code and related dead code. r=boris

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1551991 - Cleanup a bit the counter style code. r=jwatt

Use more compact types, and remove some manual implementations that can be
derived.

Depends on D31314

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1551991 - Remove nsCSSValue usage from GetPad. r=jwatt

Depends on D31315

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1551991 - Remove nsCSSValue usage for negative / suffix / prefix. r=jwatt

Depends on D31316

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1551991 - Remove nsCSSValue usage for range checks in CounterStyleRule. r=jwatt

Depends on D31317

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1551991 - Remove nsCSSValue usage of GetSymbols() GetAdditiveSymbols(). r=jwatt

Depends on D31318

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1551991 - Remove usage of nsCSSValue for SpeakAs. r=jwatt

Depends on D31319

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1551991 - Remove nsCSSValue bindings. r=jwatt

Depends on D31320

Comment 9

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This appears to be a task, as opposed to a bug. Please move back if not.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86159475ddd3
Remove legacy transform interpolation code and related dead code. r=boris
https://hg.mozilla.org/integration/autoland/rev/8a7a0329bdc3
Cleanup a bit the counter style code. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/6c1f00cc30ca
Remove nsCSSValue usage from GetPad. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/37fd602bebc2
Remove nsCSSValue usage for negative / suffix / prefix. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/c354e61f2a34
Remove nsCSSValue usage for range checks in CounterStyleRule. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/d81e4aa6bf0c
Remove nsCSSValue usage of GetSymbols() GetAdditiveSymbols(). r=jwatt
https://hg.mozilla.org/integration/autoland/rev/e12a979de502
Remove usage of nsCSSValue for SpeakAs. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/3bb3fafa62e2
Remove nsCSSValue bindings. r=jwatt

Comment 11

[Andrei Ciure[:aciure]]

Backed out 17 changesets (bug 1550554, bug 1549593, bug 1551991, bug 1529002) for failing multiple Android tests and Windows 2012 bustages

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=35f91a9ea82af8ba15ea08996149bb871d6957f8

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=2a9a034e1b6a38cba33ba668704cce7ad7a04cd3&selectedJob=246819809&searchStr=android%2C4.3%2Capi16%2B%2Cdebug%2Ctest-android-em-4.3-arm7-api-16%2Fdebug-geckoview-junit-e10s-1%2C%28gv-junit1%29

win2012 bustages: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=2a9a034e1b6a38cba33ba668704cce7ad7a04cd3&selectedJob=246815110&searchStr=windows%2C2012%2Caarch64%2Cdebug%2Cbuild-win64-aarch64%2Fdebug%2C%28b%29

backout: https://hg.mozilla.org/integration/autoland/rev/283b94c196a15367f287fd7f2bb6c9b4bcad0b45

Comment 12

[Alexandru Michis [:malexandru]]

New failure "Assertion failure: _0.ptr->data.header.header == kArcSliceCanary (Uh?), at z:/build/build/src/obj-firefox/dist/include\mozilla/ServoStyleConstsInlines.h:118"

Failure link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246826943&repo=autoland&lineNumber=993

Comment 13

[Emilio Cobos Álvarez [:emilio]]

see bug 1550554 comment 11 for the explanation.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c388ac5887c
Remove legacy transform interpolation code and related dead code. r=boris
https://hg.mozilla.org/integration/autoland/rev/5bac84efbf6d
Cleanup a bit the counter style code. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/336a076368eb
Remove nsCSSValue usage from GetPad. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/76ba2ec949d3
Remove nsCSSValue usage for negative / suffix / prefix. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/f06a39190b3d
Remove nsCSSValue usage for range checks in CounterStyleRule. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/80046630ae82
Remove nsCSSValue usage of GetSymbols() GetAdditiveSymbols(). r=jwatt
https://hg.mozilla.org/integration/autoland/rev/56b6c33c74dd
Remove usage of nsCSSValue for SpeakAs. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/d02c7d06cc79
Remove nsCSSValue bindings. r=jwatt

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41abcc264037
followup: Don't derive the destructor of CounterSpeakAs so that we can return it safely by value in Win32. r=me

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f41aae1abbba
followup: Give up on passing CounterSpeakAs by value since the previous patch busted non-Windows platforms.

Comment 17

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3c388ac5887c
https://hg.mozilla.org/mozilla-central/rev/5bac84efbf6d
https://hg.mozilla.org/mozilla-central/rev/336a076368eb
https://hg.mozilla.org/mozilla-central/rev/76ba2ec949d3
https://hg.mozilla.org/mozilla-central/rev/f06a39190b3d
https://hg.mozilla.org/mozilla-central/rev/80046630ae82
https://hg.mozilla.org/mozilla-central/rev/56b6c33c74dd
https://hg.mozilla.org/mozilla-central/rev/d02c7d06cc79
https://hg.mozilla.org/mozilla-central/rev/41abcc264037
https://hg.mozilla.org/mozilla-central/rev/f41aae1abbba

Comment 18

[Florin Strugariu [:Bebe]]

:emilio one of your bugs caused an improvment
Bugs: Bug 1529002 Bug 1550554 Bug 1551991

== Change summary for alert #21025 (as of Tue, 21 May 2019 11:14:03 GMT) ==

Improvements:

2% raptor-motionmark-htmlsuite-firefox macosx1010-64-shippable opt 37.88 -> 38.80

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21025