For some reason this patch doesn't work when I backport it to Ubuntu's Firefox 69 (which I do because I don't want to wait until December to get this fix on my machine).
Specifically, what I'm doing is (on Ubuntu 19.04) :
pull-lp-source firefox disco
patch -p1 -i ~/src/firefox/support-tiled-windows-on-gtk-final.patch # produced with hg export 5b5b21b7abc9
find -name '*.orig' -delete
debuild -S -k$GPGKEY
dput ppa:mgedmin/ppa firefox_69.0.1+build1-0ubuntu0.19.04.1mg1_source.changes
The build takes about 4 hours on the PPA builder (and local builds fail with an obscure error, so I have to rely on the PPA), after which I can install the package, and when I do I observe the following:
- normal Firefox windows have the normal title bar (round corners, extra padding in front of the first tab)
- maximized Firefox windows have the maximized title bar (square corners, first tab flush with screen edge)
- tiled Firefox windows have a mixture (round corners, first tab flush with screen edge)
Using the browser inspector (ctrl+alt+shift+i) I can see that the #titlebar element gets -moz-appearance: it should get:
-moz-window-titlebar for a regular window
-moz-window-titlebar-maximized for a maximized window
-moz-window-titlebar-maximized for a tiled window
(Ironically the browser inspector shows a /!\ icon and claims neither of the
-moz-window-titlebar values are valid choices for this property, but I assume it's just using the validator for regular browser CSS and doesn't know about the extensions used for browser chrome.)
-moz-appearance does not take effect correctly?
Further experiments with unchecking the checkbox next to
-moz-appearance in the inspector show that this property is important: when I uncheck the title bar becomes a solid bar of color (black for regular/tiled windows, white for maximized windows) instead of looking like a proper GTK headerbar.
I'm stumped and would welcome any ideas. (Also, note that local Firefox 71 builds that I used to produce and test the patch that was committed, work fine on my machine. It's just the backport that is giving me trouble.)