1551207 - No telemetry ping is sent if the "First Run Cards" are dismissed

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Nightly 68.0a1, Build ID 20190513082256

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have the "browser.ping-centre.log" pref set to true in the "about:config" page.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to the "about:welcome" page and dismiss the "First Run Modal".
3. Click the "Dismiss" button from the top right part of the page.
4. Focus the "Browser Console" and observe the displayed pings.

[Expected result]:

• An "about:welcome" dismiss ping is displayed.

[Actual result]:

• No pings are displayed.

[Notes]:

• This issue is reproducible on all branches which are containing cards.
• Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

Did we intend to add telemetry for this new type of user interaction?

Comment 2

[Nan Jiang [:nanj]]

Yes, I think we do want to collect this as the "DISMISS" event of ASRouter.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Oops. The old onboarding is missing this ping too it seems.

Comment 4

[Kate Hudson :k88hudson]

[Tracking Requested - why for this release]: This is critical for us to capture telemetry

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5023

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

merged to trailhead branch: https://github.com/mozilla/activity-stream/commit/6137844f1bab678243b8388d0a5d831d3ecb90de

Comment 7

[Ed Lee :Mardak]

We'll uplift as part of bug 1550861 which has tracking-67.0.5

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/02f031c0f789

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190515213039) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the following telemetry ping is displayed in the "Browser Console" after the "First Run Cards" are dismissed.

Comment 10

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-release/rev/df853c362664989e025d1206b59c37c435186a91