1551961 - Hover state is not removed when mouse leaves the browser window

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[vaindil]

Attachment: Shows hover states not being removed when cursor leaves the browser window

When the mouse leaves the browser window, the hover state of all elements should be removed. This is what happens in the stable branch (67) right now. In 68, however, the hover state remains when the cursor leaves the browser window. This happens to both the browser elements (like the bookmarks toolbar) and in the actual page.

I've attached a gif that illustrates this. You can see the hover actions working normally at the beginning, then I drag a Windows Explorer window up to each element (just to move the cursor off of the browser window), and the hover state remains.

Comment 1

[Peter Magyari (Desktop QA)]

Hi,

I'm going to set a component in order to involve the development team in reviewing this issue.

Thank you for your contribution!

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Dear reporter, do you think you can help with find the regression window by using mozregression tool https://mozilla.github.io/mozregression/install.html? Thank you!

I now just have MAC at hand and I couldn't reproduce this.

Comment 3

[Peter Magyari (Desktop QA)]

Hi,

This is the pushlog I've found using the mozregression tool: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=32552726554321d35a8c18224343fe73ece324c2&tochange=0930049c0ca984c909d11ba2853ef6d96e43e242

I think Bug 1534389 might be where the issue originates from.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Peter_M, thank you very much.

Hi Mike,
Could you please take a look according to comment 3? Thanks!

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Mike, do you think we can have a patch to fix this regression in 68? thanks!

Comment 6

[Mike Conley (:mconley) (:⚙️)]

The best bet might be to back out bug 1534389 (https://hg.mozilla.org/mozilla-central/rev/0930049c0ca9) from beta, to buy me more time to fix this in 69.

apavel, is backing out 0930049c0ca9 on beta something you could help me with?

Comment 7

[Andreea Pavel [:apavel]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #6)

The best bet might be to back out bug 1534389 (https://hg.mozilla.org/mozilla-central/rev/0930049c0ca9) from beta, to buy me more time to fix this in 69.

apavel, is backing out 0930049c0ca9 on beta something you could help me with?

Hi, sure.

I got mozilla@ubuntu ~/mozilla-unified beta(0) $ hg oops -er 0930049c0ca9
checking for uncommitted changes
backing out 0930049c0ca9
applying patch from stdin
patching file widget/windows/nsWindow.cpp
Hunk #2 FAILED at 613
Hunk #3 FAILED at 5309
Hunk #4 FAILED at 5343
Hunk #6 FAILED at 6170
4 out of 6 hunks FAILED -- saving rejects to file widget/windows/nsWindow.cpp.rej
patching file widget/windows/nsWindow.h
Hunk #3 FAILED at 661
1 out of 4 hunks FAILED -- saving rejects to file widget/windows/nsWindow.h.rej

To fix this all I need to do is revert the changes here https://hg.mozilla.org/mozilla-central/rev/0930049c0ca9 right?

.rej file looks like this https://pad.mozilla.org/p/changes

Comment 8

[Andreea Pavel [:apavel]]

This got backed out from beta here: https://hg.mozilla.org/releases/mozilla-beta/rev/a526d11a775d765112d0373373b667062aef4ed8

Comment 9

[Andreea Pavel [:apavel]]

(In reply to Andreea Pavel [:apavel] from comment #8)

This got backed out from beta here: https://hg.mozilla.org/releases/mozilla-beta/rev/a526d11a775d765112d0373373b667062aef4ed8

This got backed out due to build bustages: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=252021635

Backout: https://hg.mozilla.org/releases/mozilla-beta/rev/5656744772ecc4144391a76686b526be5a6e04d5

Mike there are conflicts with 1549972, please take a look.

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Mike, I'm assigning this to you as you're working with Andreea on backing out the patch where regression came from. Thank you!

Comment 11

[Mike Conley (:mconley) (:⚙️)]

I think we have to back out bug 1549972 as well - I forgot that this was based on top bug 1534389.

apavel, can you please try running:

hg backout -r 8f236d0ba0fa
hg backout -r 0930049c0ca9

and seeing if that sticks?

Comment 12

[Andreea Pavel [:apavel]]

Both bugs got backed out here https://hg.mozilla.org/releases/mozilla-beta/rev/02be9e9185f4656f0c844d74132dc59655eeff5c
No issues so far, I'll keep monitoring the tree.

Comment 13

[vaindil]

Will this be in the next beta, 68.0b13?

Comment 14

[Julien Cristau [:jcristau]]

It should be, yes.

Comment 15

[Mike Conley (:mconley) (:⚙️)]

Thanks!

Comment 16

[vaindil]

I can confirm that this problem no longer exists in 68.0b13. Sorry for the spam if you didn't need the confirmation, but thank you!

Comment 17

[Mike Conley (:mconley) (:⚙️)]

This looks like it'll be fixed when I fix bug 1547263.

Comment 18

[Mike Conley (:mconley) (:⚙️)]

Actually, I think I'm going to invert the relationship, and post the patch to this bug.

Comment 19

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1551961 - Make Windows widget layer process a mouse leave event if the mouse exits a non-client area to a non-browser window. r?jmathies

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a632277d6707
Make Windows widget layer process a mouse leave event if the mouse exits a non-client area to a non-browser window. r=jmathies

Comment 21

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/a632277d6707

Comment 22

[vaindil]

You probably don't need my feedback at this point, but I can confirm that this is fixed in 69.0b2. Thanks again!