Deleted search extensions are not rebuilt
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox69 fixed)
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: daleharvey, Assigned: chmanchester)
References
(Blocks 2 open bugs)
Details
(Keywords: in-triage)
Attachments
(1 file)
|
Bug 1552120 - Add a flag to the packager to ignore broken symlinks and pass it for developer builds.
47 bytes,
text/x-phabricator-request
|
Details | Review |
Will follow up with proper STR, however I have noticed when search extensions (https://searchfox.org/mozilla-central/source/browser/components/search/extensions) are changed, particularly deleted then the we run in issues until I fine and delete all "search-extensions" folders in my objdir
|
||
Comment 1•5 years ago
|
||
I think this is probably very similar to, or the same as bug 1500924 - see especially bug 1500924 comment 6 and onwards.
|
Assignee | |
Comment 2•5 years ago
|
||
I can replicate a failure here by trying to package after updating across 1f482a604473, indeed the problem is broken symlinks. This is sort of a known problem with JarMaker (see bug 1394576 and bug 1297381). If I use an artifact build it works fine as install manifests are used there instead of JarMaker.
Ultimately we want to use install manifests for this, but in the meantime I have a patch that adds a flag to the packager to ignore broken symlinks for developer builds. It's not ideal but I don't think it's a regression from what we have and should keep people from wasting time with this problem.
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Comment 4•5 years ago
|
||
Maybe we should just use install manifests when not doing l10n (because that's basically the only reason we don't use install manifests).
|
|
||
Comment 5•5 years ago
|
||
(as in, when --with-l10n-base is not passed)
|
|
Assignee | |
Comment 6•5 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #4)
Maybe we should just use install manifests when not doing l10n (because that's basically the only reason we don't use install manifests).
That's probably more than I can take on right now, but if you have a work in progress somewhere I'd take a look at that.
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b3197edd96a Add a flag to the packager to ignore broken symlinks and pass it for developer builds. r=firefox-build-system-reviewers,mshal
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Description
•