Closed Bug 1552237 Opened 3 months ago Closed 3 months ago

DS broken component filter again

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 68
Iteration:
68.4 - Apr 29 - May 12
Tracking Status
firefox68 --- verified

People

(Reporter: thecount, Assigned: thecount)

References

(Regression)

Details

(Keywords: github-merged)

Attachments

(1 file)

This is a regression from 1550053

While 1550053 fixed an issue with the hard coded layout, basic is now busted in a less critical way.

To test, set your browser.newtabpage.activity-stream.discoverystream.config config to: {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":false,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://getpocket.cdn.mozilla.net/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=basic"}

Try to disable either pocket or topsites in the config.

Expected, should disable them, actual, it does not.

Regressed by: 1550053
Assignee: nobody → sdowne
Iteration: --- → 69.1 - May 13 - 26
Priority: -- → P1
Blocks: 1552366
Iteration: 69.1 - May 13 - 26 → 68.4 - Apr 29 - May 12
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
No longer blocks: pocket-newtab-69

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (68.0a1 Build ID - 20190520095418) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the sections can be disabled separately.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.