1552237 - DS broken component filter again

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

This is a regression from 1550053

While 1550053 fixed an issue with the hard coded layout, basic is now busted in a less critical way.

To test, set your browser.newtabpage.activity-stream.discoverystream.config config to: {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":false,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://getpocket.cdn.mozilla.net/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=basic"}

Try to disable either pocket or topsites in the config.

Expected, should disable them, actual, it does not.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5037

Comment 2

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/c7a169c8670c

Comment 3

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (68.0a1 Build ID - 20190520095418) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the sections can be disabled separately.