Closed Bug 15529 Opened 20 years ago Closed 8 years ago

some files in js/src have no license boilerplate at all

Categories

(Core :: JavaScript Engine, defect, P3)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.0.1

People

(Reporter: dmose, Assigned: luke)

References

Details

Attachments

(3 files, 3 obsolete files)

These files need to be updated with appropriate boilerplate from
<http://www.mozilla.org/MPL/boilerplate-1.1/>.
A number of files in this list appear to be files generated during the build
process.    We do seem to be missing some licenses, but a run of your
license-testing tool on a clean tree will probably yield a clearer picture of
just what we need.
*** Bug 15528 has been marked as a duplicate of this bug. ***
Right you are; I'll generate another list.
Assignee: mccabe → rogerl
Roger, can you handle this?
Status: NEW → ASSIGNED
Blocks: 20203
Target Milestone: M13 → M14
Not going to make M13 for these.
Setting all Javacript bugs to rginda QA Contact.
QA Contact: cbegle → rginda
Got a bunch done already, working on the rest, but not for M14 anymore.
Target Milestone: M14 → M16
Target Milestone: M16 → M18
Patrick made me do this ... would you mind taking a look at the list of files 
attached (there's also a pointer to some guidelines on boilerplates) and see 
whats left to be done here. Thanks
Assignee: rogerl → pschwartau
Status: ASSIGNED → NEW
No longer blocks: 20203
Status: NEW → ASSIGNED
QA Contact: rginda → pschwartau
Milestone 0.8 has been released. We should either resolve this bug or update its
milestone.
Updating milestone - low-priority, but should be able to get to this shortly - 
my apologies.
Target Milestone: M18 → mozilla0.9
Moving out to mozilla1.0 milestone - 
Target Milestone: mozilla0.9 → mozilla1.0
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
Not sure if this bug needs this, but I've updated the list of files that I
noticed do not have licenses.  I excluded autogenerated files and binaries.
QA Contact: pschwartau → general
Assignee: pschwartau → general
Status: ASSIGNED → NEW
Assignee: general → luke
In addition to not having license boilerplate, these files seem to be totally unused, so might as well remove.
Attachment #1982 - Attachment is obsolete: true
Attachment #1984 - Attachment is obsolete: true
Attachment #149596 - Attachment is obsolete: true
Attachment #540170 - Flags: review?(brendan)
With these changes,
  find . -maxdepth 1 -o -not -type d -print | xargs head -n 40
shows copyright blurbs for all files with the exception of Y.js which is not part of the build and more a test/amusement.
Comment on attachment 540173 [details] [diff] [review]
get graydon's approval for adding standard copyright to file he committed

If I wrote it moco owns the copyright anyways, so yes.
Attachment #540173 - Flags: review?(graydon) → review+
As a clarification:  the Mozilla Foundation owns the IP.  Fine (I think, I'll ask Harvey) for the copyright notice to identify the Mozilla Corporation as the Initial Developer; code and IP developed by MoCo is owned by the Foundation.
Comment on attachment 540170 [details] [diff] [review]
remove unused files

I'm sentimental about perfect.js (it dates from 1995), but probably the right way to memorialize it is to make it a test -- r=me with that.

/be
Attachment #540170 - Flags: review?(brendan) → review+
Comment on attachment 540172 [details] [diff] [review]
get jimb's approval for adding standard copyright to file he committed

Review of attachment 540172 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #540172 - Flags: review?(jimb) → review+
http://hg.mozilla.org/mozilla-central/rev/5fe20ec0229c
with perfect.js moved to tests/
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Backed out because of broken jsreftests:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308693954.1308695404.31004.gz

http://hg.mozilla.org/mozilla-central/rev/ffd2decd02f6
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Apparently js/src/tests/perfect.js is too cute for the browser reftest harness (it worked in the shell harness).

http://hg.mozilla.org/mozilla-central/rev/56b2068a28ea
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.