1553067 - Address bar cannot find tagged bookmarks by tag

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Saad Shamsaee]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

i have bookmarked some webpages with tags,

Actual results:

when i enter the tag(s)(ie:firefox, nightly) in address bar, Firefox doesn't show the bookmarked page. however the many list items are empty still.

Expected results:

i want Firefox respect the tags, titles, and url, prioritizing in order. and be possible to change the prioritizing of these three in about:config.

Comment 1

[Marco Bonardo [:mak]]

You can restrict the results to just bookmarks typing "*" or just tags typing "+", that should help with your search. The space is limited and it's hard to always get the perfect result set for all the users.

Looking at your specific case, do I understand correctly that the urlbar panel wasn't full (it had less then 10 results) but still your bookmark did not appear?
What did you type exactly? Which tags are set on that bookmark? We need a bit more detailed steps to reproduce your bug.

Comment 2

[Marco Bonardo [:mak]]

it may also be useful to see a screenshot of the bookmark properties and one of the urlbar when you typed the tag, if possible.

Comment 3

[Saad Shamsaee]

(In reply to Marco Bonardo [::mak] from comment #1)

but still your bookmark did not appear?

What did you type exactly? Which tags are set on that bookmark? We need a bit more detailed steps to reproduce your bug.

no, my sightly bookmark didn't appear. you can see the bookmark in image:
[url=https://ibb.co/8YChDK9][img]https://i.ibb.co/J31hRBH/Untitled.jpg[/img][/url]

Comment 4

[Saad Shamsaee]

https://ibb.co/8YChDK9

Comment 5

[Marco Bonardo [:mak]]

Could you please also attach a urlbar screenshot when you try to search for it?

Comment 6

[Saad Shamsaee]

https://ibb.co/jMDktKS

maybe Nightly 69 temporary is faulty. yea? and i did not understand that we can use * and + character for find aim bookmarks. thanks.

Comment 7

[Marco Bonardo [:mak]]

if you type "firefox +" or "+ firefox" does the bookmark appear? I'm wondering if it's just a problem related to sorting results, or if it's not appearing at all.

Comment 8

[Saad Shamsaee]

not appear. just for this bookmark(https://calendar.google.com/........). but shows when i type a part of url or title.

i tested with other bookmarks. the problem is with tags.

Comment 9

[Saad Shamsaee]

Tags for bookmarks not work.

Comment 10

[Marco Bonardo [:mak]]

I cannot reproduce off-hand, even adding that same bookmark and those tags, but it's worth investigating this further, since it may be a QB regression.

Comment 11

[Marco Bonardo [:mak]]

Drew, can you reproduce this bug?

Comment 12

[Saad Shamsaee]

after update to new nightly version, tag works by type "firefox" in last items of list(i prefer to be at top of list) , and doesn't find anything by "+ firefox" character.

Comment 13

[Drew Willcoxon :adw]

(In reply to Saadi Shamsaee from comment #12)

(i prefer to be at top of list)

If you open Firefox's preferences, click the Search tab, and look for an option called "Show search suggestions ahead of browsing history in address bar results", is it checked? If so, try unchecking it. Although it looks from your screenshots that it might already be unchecked.

and doesn't find anything by "+ firefox" character.

Could you please open about:config, search for "browser.urlbar.quantumbar", set it to false, try again, and let us know whether it works?

Although iirc both awesomebar and quantumbar are using the same tokenizer now, so that might not tell us a whole lot.

Comment 14

[Drew Willcoxon :adw]

Forgot to say that I can't reproduce the problem either.

Comment 15

[Saad Shamsaee]

when "Show search suggestions ahead of browsing history in address bar results" is enabled not work without or with + . when i disable "Show search suggestions ahead of browsing history in address bar results" only works when i type "firefox" without +.

when "browser.urlbar.quantumbar" is disabled firefox works both of "firefox" and "+ firefox". practically the problem is with this config.

Comment 16

[Saad Shamsaee]

Also, when "browser.urlbar.quantumbar" is disabled and "Show search suggestions ahead of browsing history in address bar results" is enabled, with "+" works but without "+" doesn't works and doesn't suggest the bookmarked page.

Comment 17

[Saad Shamsaee]

now works true! without any update. the "browser.urlbar.quantumbar" is disable still. i don't lie.

Comment 18

[Saad Shamsaee]

i enabled "browser.urlbar.quantumbar" again and now tag works in normal type, but doesnt work with "+ firefox".

Comment 19

[Saad Shamsaee]

another bug. "Mozilla" is a tag of a bookmark. when i type it the bookmark show, but when i type "mozilla" doesn't show. its case sensitive.

Comment 20

[Marco Bonardo [:mak]]

I'll look again at this and try to see if I can figure out something.

Comment 21

[Marco Bonardo [:mak]]

Actually, in a new profile I can reproduce the bug. Unless Dao has found some hints already, I should be able to work on this.

Comment 22

[Marco Bonardo [:mak]]

I actually found 2 bugs, that I think explain this. One is that UnifiedComplete returns "tag" style instead of "bookmark-tag" style when the "tag" behavior is forced through "+". The other one is that we filter tags in a case sensitive way in the provider, so the UI doesn't receive them.
I'll make a try build and ask you to test it, likely tomorrow.

Comment 23

[Marco Bonardo [:mak]]

This is a Try build, I suggest to make a backup of your profile before using it, in any case, of you can just try to copy your place.sqlite and prefs.js from your profile to a new one.
https://queue.taskcluster.net/v1/task/KMpRkVkyTD6Q8HJ4m0M2Yw/runs/0/artifacts/public/build/target.zip

Please let me know if this solves the problem, so I know I'm on the right way.

Comment 24

[Saad Shamsaee]

yes, the problem is fixed in this build.

Comment 25

[Marco Bonardo [:mak]]

Thank you for confirming, tomorrow I'll write tests and move on with this change

Comment 26

[Marco Bonardo [:mak]]

Attachment: Bug 1553067 - Quantum Bar may not return bookmark tags correctly. r=adw

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/956a54ed03c7
Quantum Bar may not return bookmark tags correctly. r=adw

Comment 28

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/956a54ed03c7

Comment 29

[Marco Bonardo [:mak]]

Comment on attachment 9067736 [details]
Bug 1553067 - Quantum Bar may not return bookmark tags correctly. r=adw

Beta/Release Uplift Approval Request

• User impact if declined: Tagged bookmarks cannot be found properly in the address bar
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: In a new profile add a bookmark with tags "Firefox, Mozilla", try to search in the urlbar for "firefox" or "+ firefox" and find the tagged bookmark.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix is limited to minimum portions of the feature and simple, it has tests.
• String changes made/needed: none

Comment 30

[Oana Botisan, Desktop QA]

I only managed to partially reproduce the issue. The only time when the older builds didn't find the bookmark was when I used "+". I tested this using Nightly from 2019-05-21 on Windows 10 x64.
I retested everything using the latest Nightly 69.0a1 on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64 and I can't reproduce the issue anymore.

Comment 32

[Julien Cristau [:jcristau]]

Comment on attachment 9067736 [details]
Bug 1553067 - Quantum Bar may not return bookmark tags correctly. r=adw

quantumbar fix, approved for 68.0b7

Comment 33

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/49da76e97a02

Comment 34

[Oana Botisan, Desktop QA]

I verified the fix on beta 68.0b7 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The bug is not reproducing anymore.

Comment 35

[metabind]

• 78.0.2 (64-bit)
• OpenSUSE
• Linux 5.7.7-1-default
• 64-bit

Not every bookmark associated with a given tag is shown when using "+" (or any other special character) in the address bar.