Closed Bug 1553124 Opened 3 months ago Closed 3 months ago

Disable Bing, DDG, Google and Yandex search engine tests for Thunderbird (since TB doesn't have partner codes)

Categories

(Firefox :: Search, task)

task
Not set
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 69
Iteration:
69.1 - May 13 - 26
Tracking Status
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: jorgk, Assigned: jorgk)

Details

Attachments

(2 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1541415 +++

Disable Bing, DDG, Google and Yandex search engine tests for Thunderbird (since TB doesn't have partner codes)

No longer blocks: 1541196, 1541417, 1552188
No longer depends on: 1541210, 1541415
Attachment #9066398 - Attachment description: Bug 1553124 - Disable Bing, DDG, Google and Yandex search engine tests for Thunderbird. → Bug 1553124 - Disable search engine-specific tests for Thunderbird.
Attachment #9066396 - Attachment is obsolete: true
Attachment #9066624 - Flags: review+

I've carried over Mark's (standard8) r+ from Phab and attached the identical patch. r=standard8 since Mark/standard8 is the reviewer.

Dear Sheriff, please land the patch the "classic way" since Lando doesn't work for patches uploaded into Phab via the web upload UI (bug 1529506).

In reply to Mark's Phab comment

is there a reason you're not using moz-phab or similar to upload these?

Yes, the moz-phab setup for Windows is a 12-step process https://moz-conduit.readthedocs.io/en/latest/arcanist-windows.html and I have three development machines, so I find this effort prohibitive.

I filed bug 1529506 to make the integration work, so patches uploaded via the web upload UI that I and a few TB colleagues are using would work. That bug was hijacked and instead of fixing the issue, they added a banner advising that it doesn't work, see "re-badging" of the bug after bug 1529506 comment #4.

Keywords: checkin-needed

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d4857727683
Disable search engine-specific tests for Thunderbird. r=standard8

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

I uplifted this as I was uplifting a couple of other of the test-only changes for 68, and this made sense to go with those.

https://hg.mozilla.org/releases/mozilla-beta/rev/a722f0934123

Thanks, Mark!

You need to log in before you can comment on or make changes to this bug.