1553416 - Show or test system add-ons with shortcuts at "Manage shortcuts" (e.g. Screenshots)

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Rob Wu [:robwu]]

System add-ons are currently not shown at the "Manage Shortcuts" view of about:addons.

To offer maximum customizability (and otherwise at least awareness) of their shortcuts, I propose to make a change to render system add-ons with shortcuts in the "Manage Shortcuts" view (despite them being hidden from the rest of about:addons). This allows users of the Screenshot add-on to see and change its shortcut.

Regardless of whether system add-ons are shown, we should add test coverage to avoid bugs like bug 1551563.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1553416 - Show system add-ons with shortcuts

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2ec538a2cd8
Show system add-ons with shortcuts r=mixedpuppy,kmag

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e2ec538a2cd8

Comment 4

[Alex Cornestean]

Verified as Fixed on the latest versions of Nightly (69.0a1 / 20190604214415) under Windows 10 Pro 64-bit and macOS High Sierra 10.13.6.

Firefox Screenshots is properly displayed at "Manage shortcuts" and functions correctly.