Closed Bug 1553448 Opened 3 months ago Closed 3 months ago

[about:addons] Disabled menu items do not have a lighter color in HTML about:addons

Categories

(Toolkit :: Add-ons Manager, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 --- verified
firefox69 --- verified

People

(Reporter: cbadescu, Assigned: robwu)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Attached image Bug1550863.png

[Affected versions]:

  • Firefox 69.0a1(20190521214552)
  • Firefox 68.0b3(20190520131124)

[Affected platforms]:

  • Win 7 64-bit
  • Mac OS X 10.14.1

[Prerequisites]

  • Set the preference extensions.htmlaboutaddons.enabled to true and restart the browser

[Steps to reproduce]:

  1. Navigate to Add-ons Manager (about:addons page)
  2. Click on “Plugins”.
  3. Click on “More Options” button from “OpenH264...etc”.
  4. Observe the “Ask to Activate” menu item.

[Expected results]:

[Actual results]:

  • The menu item has the black color.

[Notes]
The patch that caused this regression https://hg.mozilla.org/mozilla-central/rev/2519b62544a9dae3fb29c59294420498ca637f8f#l4.6

Please see the attached screenshot.

Assignee: nobody → rob
Status: NEW → ASSIGNED
No longer blocks: 1551202
  • Render "hidden" appearance via opacity. This fixes the reported
    regression, and also results in a desired fading of the icon (if any).
  • Set cursor to "default" avoid "pointer" cursor in menu items.
  • Let the "checked" icon adapt the color of the style sheet (e.g. to
    account for dark themes) instead of using the default black color.
Priority: -- → P1
Summary: Disabled menu items do not have a lighter color → [about:addons] Disabled menu items do not have a lighter color in HTML about:addons
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/596487d6126a
Improve appearance of card menu at about:addons r=mstriemer,jaws
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Attached image Bug1553448.gif

This issue is verified as fixed on Firefox 69.0a1 (20190529215251) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.

Status: RESOLVED → VERIFIED

Comment on attachment 9066713 [details]
Bug 1553448 - Improve appearance of card menu at about:addons

Beta/Release Uplift Approval Request

  • User impact if declined: The triple-dot menu of extension cards at HTML about:addons has incorrect colors when dark theme is enabled, and also other minor visual issues (icon positioning in right-to-left locales, cursor appearance). HTML about:addons is currently off by default, but will be enabled before 68 hits release.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Patch is small and focused. The feature is off by default (bug 1555012 tracks enabling by default).
  • String changes made/needed: none
Attachment #9066713 - Flags: approval-mozilla-beta?

Comment on attachment 9066713 [details]
Bug 1553448 - Improve appearance of card menu at about:addons

tweak for new about:addons, approved for 68.0b7

Attachment #9066713 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This issue is verified as fixed on Firefox 68.0b7 (20190603181408) under Win 7 64-bit and Mac OS X 10.14.1.

You need to log in before you can comment on or make changes to this bug.