1553768 - [de-xbl] remove the menu-vertical, appmenu-vertical bindings - convert to <toolbarbutton is="toolbarbutton-appmenu">

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

Bug 1546309 will remain for splitmenu and general rework of the appmenu, but we need to fix the actual appmenu button now since bug 1519577 is landing.

This bug will remove the menu-vertical, appmenu-vertical bindings and convert it to <toolbarbutton is="toolbarbutton-appmenu">.

The patch applies on top of bug 1547233.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1553768_appmenu-dexbl.patch

On top of the patch in bug 1547233 (refreshing that in a minute)

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1553768_appmenu-dexbl.patch

Including the added file

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/42690276c3c0
[de-xbl] remove the menu-vertical, appmenu-vertical bindings - convert to <toolbarbutton is="toolbarbutton-appmenu">. rs=bustage-fix,jorgk

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/30859b715661
Follow-up: fix linting error. r=me

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9066995 [details] [diff] [review]
bug1553768_appmenu-dexbl.patch

Review of attachment 9066995 [details] [diff] [review]:
-----------------------------------------------------------------

Other than that really minor indentation style, LGTM.
r=aleca

::: mail/base/content/toolbarbutton-appmenu.js
@@ +48,5 @@
> +    }
> +  }
> +  customElements.define("toolbarbutton-appmenu",
> +    MozToolbarButtonAppmenu, { extends: "toolbarbutton" }
> +  );

nit: this seems like a strange indentation style we don't use anywhere else.