1553835 - the pip window should open in a floating window in tiling window managers

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[jaap.aarts1]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

open a pip window(youtube) in i3wm(tiling window manager)

Actual results:

a separate window was opened pushing the main window aside, showing ugly white bars. I have to manually make the window floating to make PIP useful

Expected results:

the new window should be in floating mode from the start putting it in some corner or in the center of the screen.

Comment 1

[Florencia Di Ciocco, NI to vbalducci]

Hi Jaap.aarts1,

I'm very sorry for the delay in answering you. I was unable to reproduce this issue on Ubuntu 16.04 with Firefox Nightly 68. But maybe you can provide me with a bit more info.

Can you please download Firefox Nightly from here: https://nightly.mozilla.org/ and retest the problem and see if the issue still occurs there as well?
Does this issue occur with a fresh profile? you can find the steps here: https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

If after doing this you can still reproduce the bug, could you send me a screenshot or a video of the bug? That always helps a lot.

Thanks in advance, Flor.

Comment 2

[jaap.aarts1]

Hi Flor,

I can reproduce this in nightly 06-19.
Expires in 7 days/5 uploads(can use any other method, but just thought why not try out ff-send)
https://send.firefox.com/download/146b4ab63f992c27/#tEnr1gtCLircunTvdTcKZQ

A lot of other "pop-up" windows also have the same issue, but those are not used frequently and don't have the same "needs to be on top" kinda function. The help->about for example. But the profile creation window does make the window floating making it visible on top of Firefox.

Comment 3

[Florencia Di Ciocco, NI to vbalducci]

Hi again,

Thanks for your fast answer. The video is of less than a second long so I can't truly appreciate it. Do you mind sending it again? But of like 5 to 30 seconds?

Thanks in advance, Flor.

Comment 4

[jaap.aarts1]

hmm, for me the video is complete (18 seconds).
does this work?:
https://drive.google.com/file/d/19QRwO6QlvuLILpLvKllx4EA-E7F58sn6/view?usp=sharing

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

ni to mconley for PiP triage

Comment 7

[jaap.aarts1]

This was fixed in a recent release of nightly, but it has been re-introduced since the white-bar removal.
It worked fine for the 3 days, the code probably got overwritten by the white-bar removal.

Comment 8

[Dennis van der Schagt [:dennisschagt]]

Attachment: Bug 1553835 - Set GTK window hint to make PIP window floating

Comment 9

[Martin Stránský [:stransky] (ni? me)]

I'll look at it, Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a84453ce1c9
Set GTK window hint to make PIP window floating r=stransky

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3a84453ce1c9