Closed Bug 1554511 Opened 3 months ago Closed 3 months ago

Port bug 336267 If software update is 'ask' after an update has been downloaded, the update should be disabled or asked

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

When changing the update setting from "Automatically install updates (recommended)" to "Check for updates but let you choose to install them" if there is an existing update in progress there is no option to discard it. This is especially problematic when someone downloads an older build to test something since the update could already be in progress before changing this setting and the older build will end up being updated out from under them.

Port of https://hg.mozilla.org/mozilla-central/rev/6e27e86c9ab0. I haven't tested it as I don't know how I could. But this code, and our existing update code, is the same as FX uses.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9067634 - Flags: review?(jorgk)
Comment on attachment 9067634 [details] [diff] [review]
1554511-cancel-running-update-when-disabling.patch

Thanks, straight port. I'll land it now and you can test in Daily as discussed on IRC.
Attachment #9067634 - Flags: review?(jorgk) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0cc63242c9a4
Port bug 336267: When disabling automatic updating and there is an update in progress, ask the user if they want to cancel the update. r=jorgk DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED

Checked the function. When it was on "Automatically install updates" and it downloads the update, and I switch to "Check for updates, but let me choose whether to install them", it ask me what to do with the downloaded update.

Status: RESOLVED → VERIFIED

Nice :-)

You need to log in before you can comment on or make changes to this bug.