1554511 - Port bug 336267 If software update is 'ask' after an update has been downloaded, the update should be disabled or asked

Status: VERIFIED FIXED

(Thunderbird :: General, enhancement)

Description

[Richard Marti (:Paenglab)]

When changing the update setting from "Automatically install updates (recommended)" to "Check for updates but let you choose to install them" if there is an existing update in progress there is no option to discard it. This is especially problematic when someone downloads an older build to test something since the update could already be in progress before changing this setting and the older build will end up being updated out from under them.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1554511-cancel-running-update-when-disabling.patch

Port of https://hg.mozilla.org/mozilla-central/rev/6e27e86c9ab0. I haven't tested it as I don't know how I could. But this code, and our existing update code, is the same as FX uses.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9067634 [details] [diff] [review]
1554511-cancel-running-update-when-disabling.patch

Thanks, straight port. I'll land it now and you can test in Daily as discussed on IRC.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0cc63242c9a4
Port bug 336267: When disabling automatic updating and there is an update in progress, ask the user if they want to cancel the update. r=jorgk DONTBUILD

Comment 4

[Richard Marti (:Paenglab)]

Checked the function. When it was on "Automatically install updates" and it downloads the update, and I switch to "Check for updates, but let me choose whether to install them", it ask me what to do with the downloaded update.

Comment 5

[Jorg K (CEST = GMT+2)]

Nice :-)